Add PubSub and ReactiveStore utilities #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
approved these changes
Jan 27, 2025
| */ | ||
| export default class PubSub { | ||
| constructor() { | ||
| this._subscribers = new Map(); |
There was a problem hiding this comment.
Nit: if you do feel like using #privateVariables, feel free! We've started using them more liberally in core lately.
There was a problem hiding this comment.
Cool! I didn't know we officially supported the new syntax now. I'll make a separate PR to update these once I have a bit of time again.
jorge-ramirez-arredondo
deleted the
jorge-ramirez-arredondo/ReactiveStore
branch
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new
ReactiveStoreutility (and adds thePubSubutility since the Reactive Store is dependent on it).This PR is pretty big since it includes fairly detailed READMEs and tests for both the
ReactiveStoreandPubSubutilities, as well as demos for theReactiveStore.See the prototype sandbox for the
ReactiveStorehere: https://codesandbox.io/p/sandbox/reactive-store-prototype-vhz76g?workspaceId=ws_FRqmQNTVG95dm2hG2FbpSi