Bug fix: use hourCycle instead of hour12 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
approved these changes
Aug 10, 2020
|
🎉 This PR is included in version 3.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following behavior when using
formatDateStringto parseTue Feb 27 2018 00:00:00 GMT-0500 (Eastern Standard Time).In chrome:
Becomes
02/27/2018, 24:00:00 EST(INCORRECT)In Firefox:
Becomes
02/27/2018, 00:00:00 EST(CORRECT)This 24hr time was causing dates to appear as the next day (e.g., would be displayed as Feb 28, 2018 12 AM)
I found this thread https://support.google.com/chrome/thread/29828561?hl=en that mentions this and a reply suggest to use
hourCycle: h23and removehour12, which does seem to fix it in my use case.