Add Hawaiian to supported languages #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,7 @@ export const supportedLocalesDetails = [ | |||
| { code: 'fr-ca', dir: 'ltr', name: 'Français (Canada)' }, | |||
| { code: 'fr-fr', dir: 'ltr', name: 'Français (France)' }, | |||
| { code: 'fr-on', dir: 'ltr', name: 'Français (Ontario)' }, | |||
| { code: 'haw-us', dir: 'ltr', name: 'ʻŌlelo Hawaiʻi (ʻAmelika Hui Pū ʻIa)' }, | |||
There was a problem hiding this comment.
is -us necessary for haw?
There was a problem hiding this comment.
Specifically, instead of haw-haw
There was a problem hiding this comment.
Regions must be a valid ISO 3166 code. It's arguable whether using them at all for some languages is necessary, but I'm uncertain if leaving it off breaks stuff in the rest of the system. We may use it for figuring out which number system to use for example in the LMS so for now we just keep it consistent.
KearseTrevor
approved these changes
Jan 13, 2025
|
🎉 This PR is included in version 3.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAUD-7412: Add
hawas supported language inbrightspace-ui/intlAdds
haw/haw-usas a supported lang/locale. More data for dates/times, numbers etc. will be added separately.