US152268 - Migrate async-container-mixin and typography tests #3937
Conversation
| mixins/*/test/screenshots/current/ | ||
| mixins/*/test/screenshots/golden/ |
There was a problem hiding this comment.
async-container-mixin is the only vdiff test in mixins so we can clean this up now. You'll need to clean up any lingering local copies next time you pull after this merges.
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
| @@ -0,0 +1,54 @@ | |||
| import '../typography.js'; | |||
There was a problem hiding this comment.
So including this is a little bit conflict-y with what vdiff is already including. It's probably fine, but we'll need to be careful to keep them in sync if we ever publish new versions of those assets to the CDN.
There was a problem hiding this comment.
Yeah I can't really think of a way around it to still test the typography code, unless we isolated the typography tests into their own job and created a custom testRunnerHtml for them?
There was a problem hiding this comment.
Yeah doesn't seem worth the trouble since this is working.
Co-authored-by: github-actions <[email protected]>
svanherk
deleted the
US152268_Migrate_async-container-mixin_and_typography_tests
branch
|
🎉 This PR is included in version 2.141.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Nothing super interesting about the typography migration.
For the
async-container-mixinmigration, I modified the existingdemo/async-item.jscomponent so thattest/async-item.jscould be deleted. The result is that two of the diffs are a slightly bigger version of themselves now, because the demo size was100pxand the test size was50px.Final report: https://vdiff.d2l.dev/BrightspaceUI/core/dfedfcf7f988a2343d7d800b25a04108255c65d0/2023-08-28_19-26-07/report/