Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step to create rexray secrets #30

Closed
kaustavb12 opened this issue Jun 17, 2021 · 1 comment · Fixed by #31
Closed

Step to create rexray secrets #30

kaustavb12 opened this issue Jun 17, 2021 · 1 comment · Fixed by #31

Comments

@kaustavb12
Copy link
Contributor

Hi @BretFisher

Following the steps of deployment in README,
in Step 1, the REXRAY_DO_TOKEN env. variable is set and in Step 5, external secrets rexray_do_token is used during deployment of the rexray stack.

However this secret is not created at any step prior to Step 5.

A command such as echo $REXRAY_DO_TOKEN | docker secret create rexray_do_token - could be included in Step 5, prior to the stack deployment command or a new step 5 can be added can be added and subsequent steps renumbered.

I could open a PR for the same, if you agree.

@BretFisher
Copy link
Owner

Sure, just add it to step one in a PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants