Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pypi release #136

Open
BenPru opened this issue Sep 12, 2023 · 13 comments
Open

New pypi release #136

BenPru opened this issue Sep 12, 2023 · 13 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@BenPru
Copy link
Collaborator

BenPru commented Sep 12, 2023

Hello heatpump lovers,
heating season is near. Although my time is short, I would like to advance the new code base of the HA component.
If someone would like to support, you can install the preview or make code review for the core module.

For the new code I use luxtronik==0.3.14 and the new functions with an own Luxtronik class. (But time.sleep is not allowed in a core module...)

It would be great if we could get a new stable version here that I can then use.
What is missing for a new stable version?

@BenPru BenPru added help wanted Extra attention is needed question Further information is requested labels Sep 12, 2023
@BenPru BenPru pinned this issue Sep 12, 2023
@FnTm
Copy link

FnTm commented Oct 4, 2023

Sorry about the additional ping @Bouni or @kbabioch, but I'm also really looking forward to a new pypi release. Can we help in some way to get that going?

@gerw
Copy link
Collaborator

gerw commented Oct 4, 2023

Yes, this would be nice. But I think that there are some issues which should be addressed before a new release, e.g., #132 and maybe also #135?

@kbabioch
Copy link
Collaborator

kbabioch commented Oct 4, 2023

I will take another look at #135.

@FnTm
Copy link

FnTm commented Jan 11, 2024

@Bouni or @kbabioch sorry to bother you folks, but is there some way to get the new pypi release made?

@Bouni
Copy link
Owner

Bouni commented Jan 15, 2024

Hey everyone, sorry for the long silence from my side but personal things had (still have) priority over hobby projects 😓
I actually lost tack of what we added after 0.3.14 and whats necessary to release a stable 0.3.15 or even a 0.4.0

@kbabioch @gerw @BenPru what do you guys think is necessry for a new release. Can we might just release a intermediate 0.3.15 version now and a lets say 0.4.0 when the features are complete we inteded for the next "big" release?

@gerw
Copy link
Collaborator

gerw commented Jan 15, 2024

Yes, I think 0.3.15 could be a good next step. I think we should have a further look at #132, since the issue discussed there is a significant change to the API w.r.t. 0.3.14.

@Bouni
Copy link
Owner

Bouni commented Feb 9, 2024

@gerw Do you think #132 is a must have for a 0.3.15 release?

If not I would like to release 0.3.15 and we can plan on having #132 for the 0.3.16 or whatever release in the future.

@gerw
Copy link
Collaborator

gerw commented Feb 9, 2024

@Bouni At least we should discuss, how we handle that issue. Currently, main has a breaking API change compared to 0.3.14 and that issue proposes to revert this breaking change. From my point of view, it does not make sense to release 0.3.15 with this braking change and then revert it in 0.3.16.

[The API change is that parameters is no longer a member of Luxtronik. Instead read() returns the parameters.]

@gerw
Copy link
Collaborator

gerw commented Feb 19, 2024

@Bouni Now, #163 is almost finished. After merging, I propose to deal with #128 (should be a quick one). It would also be nice, to start a basic changelog, see #135.

Actually, what has been changed since 0.3.14?

  • Identified datatype of many parameters / calculations
  • Internal refactoring
  • The connection to the heat pump is reused (instead of connect & disconnect for each read/write operation)
  • TBD: New way to access the software version (Provide software version #128)

@Bouni
Copy link
Owner

Bouni commented Feb 19, 2024

I guess we have to do the changelog for a new version manually this time. Afterwards I tend to introduce commitlint / conventionalcommits to ensure commit messages that allow for a semi-automatic changelog generation.

What do you guys think about this?

@gerw
Copy link
Collaborator

gerw commented Feb 20, 2024

Guzz-T found some incompatibilities to 0.3.14 in #132. These should also mentioned in the change log.

I have no experience with this, but we could try conventionalcommits. Do I get it right, that every commit will end up in the change log?

@gerw
Copy link
Collaborator

gerw commented Feb 21, 2024

I took the liberty to create a new milestone for the next release. This way we can focus on the necessary changes to publish the release in the next time.

@gerw gerw added this to the New pypi release 0.3.15 milestone Feb 21, 2024
@gerw
Copy link
Collaborator

gerw commented Apr 1, 2024

ping @Bouni @kbabioch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants