-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runescape on rpi (java app) #2530
Comments
@Botspot |
Please use the proper issue template or actually provide a zip or PR link of which what you have provided is neither. App submissions should follow our developer documentation for making a pi-apps compatible submission https://pi-apps.io/wiki/development/Creating-an-app/ |
Will do |
Here is the zip. |
A zipfile was found in the body of an issue comment. Click to show contents preview
|
You still do not understand what the format for the zip is. Pi-Apps applications must have particular install/uninstall scripts using standardized pi-apps functions. Again, please read the developer documentation https://pi-apps.io/wiki/development/Creating-an-app/ . Pi-Apps also has a "new app" GUI walkthrough available from the pi-apps settings that will help you develop an app for pi-apps. |
Okay i will read through it again and make some changes. |
@theofficialgman @Botspot Have a good day :) |
A zipfile was found in the body of an issue comment. Click to show contents preview |
The zip is entirely empty. Also there is no need to @ the developers each time. We already get notifications. |
Sorry |
Here's the fixed zip file. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir games
cd games
mkdir RuneLite
cd RuneLite
sudo apt update && sudo apt upgrade -y
sudo apt-get install openjdk-17-jdk
#Download
wget https://github.com/runelite/launcher/releases/download/2.4.0/RuneLite.jar || error 'Failed to download repository!'
wget https://support.runescape.com/hc/article_attachments/360002378849/RS_Rune_final.png || error 'Failed to download repository!'
convert -resize 64x64 RS_Rune_final.png icon-64.png
rm -r $HOME/games/RuneLite/RS_Rune_final.png
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite
Comment=Open Source RuneScape Launcher
Icon=$HOME/games/RuneLite/icon-64.png
Exec=java -jar $HOME/games/RuneLite/RuneLite.jar
Path=$HOME/games/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
Categories=Game;" > ~/.local/share/applications/RuneLite.desktop
#!/bin/bash
#Deleting game files
rm -r $HOME/.runelite/
rm -r $HOME/games/RuneLite/
rm -rf ~/.local/share/applications/RuneLite.desktop
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
I have got a video of the script running through pi-apps on my raspberry pi. Untitled.-.Sequence.01.3.mp4 |
Please again refer to the documentation https://pi-apps.io/wiki/development/Creating-an-app/ The biggest one is don't use apt directly, refer to the documentation for what to use. Additionally, we prefer that applications be installed globally and definitely not in their own custom directory in the home folder. There are a lot of other scripts in pi-apps that do this already, you can search for some on github by looking for |
I will follow you advice and edit the script and make it better :) |
Here is the zip. I had to follow the the documentation on https://pi-apps.io/wiki/development/Creating-an-app/ for a bit of help but i think this is ready to be put on pi-apps :) |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" > ~/.local/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite"
#!/bin/bash
#Deleting game files
rm -rf $HOME/.runelite/
rm -rf $HOME/RuneLite/
rm -rf ~/.local/share/applications/RuneLite-OSRS.desktop
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
Had to update the description but here is the zip file for my app. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" > ~/.local/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite"
#!/bin/bash
#Deleting game files
rm -rf $HOME/.runelite/
rm -rf $HOME/RuneLite/
rm -rf ~/.local/share/applications/RuneLite-OSRS.desktop
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
Better. However you still missing error handling on install_packages (refer to the documentation again) And again, we would prefer that applications be installed globally. Use the github search for |
Also, is this folder used for save data? |
Its the clients save data but old school runescape saves you save data to the cloud through jagex account. Should I change it so the clients save data stays on the raspberry pi 4 after being uninstalled? |
I will change that and send you and updated zip with the scripts in |
yes please. |
Will do thanks for the advice :) |
I have fixed what you told me to do with the script and looked at the pi-apps documentation for help with it anyway, |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite"
#!/bin/bash
#Uninstalling
rm -rf $HOME/RuneLite/
sudo rm -rf ~/usr/share/applications/RuneLite-OSRS.desktop
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
never mind i forgot to save one thing in it i will send you another updated one |
Here is the zip again after my silly mistake. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite"
#!/bin/bash
#Uninstalling
rm -rf $HOME/RuneLite/
sudo rm -rf ~/usr/share/applications/RuneLite-OSRS.desktop
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
Never mind after looking at the uninstall script I have done another silly mistake 😅 I'll fix it |
Here is the zip after that silly mistake revolving the desktop entry not deleting on the last zip i sent you. Sorry if it seems like i'm spamming. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite"
#!/bin/bash
#Uninstalling
rm -rf $HOME/RuneLite/
sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!"
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
😑 I have just Realized a mistake in the description i have done i will fix it now |
Fixed it all now. Finally anyway here's the zip. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite-OSRS
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite RuneLite-OSRS"
#!/bin/bash
#Uninstalling
rm -rf $HOME/RuneLite/
sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!"
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
i have just realized another thing i have messed up anyway mi going to fix it. |
Finally i got a script with no mistakes in here it is. Hope you like it :) |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite-OSRS
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite-OSRS"
#!/bin/bash
#Uninstalling
rm -rf $HOME/RuneLite/
sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!"
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
Sorry it was unfair to have some of our reference scripts not install globally as is our current intention. |
Okay |
I have looked at both install/uninstall scripts for Shattered Pixel Dungeon to see what i could change on my install/uninstall script. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
cd $HOME
mkdir RuneLite
cd RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd RuneScape-on-Linux
cp RuneLite.jar $HOME/RuneLite
rm -rf $HOME/RuneLite/RuneScape-on-Linux/
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite-OSRS
Comment=Open Source RuneScape Launcher
Icon=$(dirname "$0")/icon-64.png
Exec=java -jar $HOME/RuneLite/RuneLite.jar
Path=$HOME/RuneLite/
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop >/dev/null || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite-OSRS"
#!/bin/bash
#Uninstalling
rm -rf $HOME/RuneLite/
sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!"
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
You are missing the point. your install is not global. Your files (game and icon) reside in the specific users home folder Please refer again to shattered pixel dungeon. it is a perfect match for runscape. All you need to do is take those scripts and change the links/paths for runescape |
Thank for letting me know what I did wrong I will fix it :) |
I have actually made the install global now. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
sudo mkdir -p /usr/local/share/RuneLite || error "Could not make directory!"
cd /usr/local/share/RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
sudo git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd /usr/local/share/RuneLite/RuneScape-on-Linux
sudo cp RuneLite.jar /usr/local/share/RuneLite
sudo rm -rf /usr/local/share/RuneLite/RuneScape-on-Linux/
# install application icons
sudo cp "$(dirname "$0")/icon-64.png" /usr/local/share/icons/hicolor/64x64/apps/RuneLite-OSRS.png || error "Failed to install RuneLite-OSRS icon!"
# update timestamp of top level icon directory to signal icon cache to be refreshed
sudo touch /usr/local/share/icons/hicolor
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite-OSRS
Comment=Open Source RuneScape Launcher
Icon=RuneLite-OSRS
Exec=java -jar /usr/local/share/RuneLite/RuneLite.jar
Path=/usr/local/share/RuneLite
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop >/dev/null || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite-OSRS"
#!/bin/bash
#Uninstalling
sudo rm -rf /usr/local/share/RuneLite/
sudo rm -rf /usr/local/share/icons/hicolor/64x64/apps/RuneLite-OSRS.png
sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!"
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
better. I will ignore the remaining issues with the script global installation for now. Lets discuss the issues with obtaining runscape
Why are we cloning your git repo? runelite is available from upstream directly -> https://github.com/runelite/launcher/releases/tag/2.6.10 which is what is linked on the website https://runelite.net/ |
Because I don't know how to clone a release without using wget which the pi-apps documentation says not to. Is there a way to clone releases? If so, could you tell me how? |
you are mistaken. read the documentation again, it does not say that. it says that you cannot CLONE a github REPO with wget, not that you cannot DOWNLOAD a github release asset with wget. the documentation is simply informing users that git repositories cannot be download with wget as this is a common misconception by first time script writers and users of git. |
I'm sorry I misunderstood as I am a first-time script writer I will edit my script and get back to you with a updated zip. |
Here is the updated script using the official runelite github repo release. |
A zipfile was found in the body of an issue comment. Click to show contents preview
#!/bin/bash
sudo mkdir -p /usr/local/share/RuneLite || error "Could not make directory!"
cd /usr/local/share/RuneLite
#Download
install_packages openjdk-17-jdk || exit 1
sudo wget https://github.com/runelite/launcher/releases/download/2.6.10/RuneLite.jar || error 'Failed to download release from repository!'
# install application icons
sudo cp "$(dirname "$0")/icon-64.png" /usr/local/share/icons/hicolor/64x64/apps/RuneLite-OSRS.png || error "Failed to install RuneLite-OSRS icon!"
# update timestamp of top level icon directory to signal icon cache to be refreshed
sudo touch /usr/local/share/icons/hicolor
#Desktop shortcut
echo "[Desktop Entry]
Name=RuneLite-OSRS
Comment=Open Source RuneScape Launcher
Icon=RuneLite-OSRS
Exec=java -jar /usr/local/share/RuneLite/RuneLite.jar
Path=/usr/local/share/RuneLite
Type=Application
Encoding=UTF-8
Terminal=false
StartupNotify=true
Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop >/dev/null || error "Failed to create menu button!"
echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux.
To run: Menu -> Games -> RuneLite-OSRS"
#!/bin/bash
#Uninstalling
sudo rm -rf /usr/local/share/RuneLite/
sudo rm -rf /usr/local/share/icons/hicolor/64x64/apps/RuneLite-OSRS.png
sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!"
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
No need to apologize. I am not mad (bold text just for emphasis). I recognize you are a first time script writer and expect these things. |
What is the name of the app?
Runelite (OSRS)
(Optional) Where is the app hosted?
https://github.com/DatBoiG265/RuneScape-on-Linux
About the app
A Script that installs Runelite an Old School RuneScape client onto your Raspberry Pi
Tested on Raspberry pi 4 Model B (4gb) with Raspberry pi os Bookworm 64bit
Confirmations
The text was updated successfully, but these errors were encountered: