Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using music-metadata 7.x instead on 8.x #945

Closed
AlbanWS opened this issue Sep 14, 2023 · 3 comments
Closed

Using music-metadata 7.x instead on 8.x #945

AlbanWS opened this issue Sep 14, 2023 · 3 comments

Comments

@AlbanWS
Copy link

AlbanWS commented Sep 14, 2023

Hi,

Currently using music-metadata-browser (what an incredibly good project), I am facing a warning in Vite:

node_modules/file-type/core.js (1419:16) Use of eval in "node_modules/file-type/core.js" is strongly discouraged as it poses security risks and may cause issues with minification.

After seeking the reason of this warning, I saw that music-metadata-browser currently depends on "music-metadata": "^7.13.3", which depends on "file-type": "^16.5.4", which uses an eval in its code base.

Since "music-metadata": "8.1.4" depends on "file-type": "^18.2.1" (not uning eval anymore), I would suggest to update the dependencies to "music-metadata": "8.1.4";

I could help creating pull request if want me to.

Thanks.

@Borewit
Copy link
Owner

Borewit commented Sep 23, 2023

Updating music-metadata version 7 to 8 is not straightforward, as version 7 is CJS and 8 is ESM.

Ideally music-metadata version 8 should take over the browser functionality. I made a start here: https://github.com/Borewit/music-metadata/tree/es-module-with-browser-support

Long time a ago, totally forgot what needs to be done. Your help is very much welcome, but be aware this is not easy task.

@AlbanWS
Copy link
Author

AlbanWS commented Sep 25, 2023

Thank you for the information, I will take a look then !

@Borewit
Copy link
Owner

Borewit commented Jul 10, 2024

music-metadata v9.0.0 took over browser functionality, this music-metadata-browser is obsolete.

@Borewit Borewit closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants