Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search index improvements #5488

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Search index improvements #5488

merged 5 commits into from
Feb 14, 2025

Conversation

ssddanbrown
Copy link
Member

  • Adds more advanced indexing to retain terms joined with certain punctuation (.-).
  • Adds «giullemets» as term delimiters.
  • Breaks out search tests into multiple classes within their own dir.

From testing, custom indexing tokenization slows indexing speed by about 5-10% on my dev instance (37k pages).
Seems within reason, will be minor actual speed impact in normal use.

Re-indexing may be needed to receive benefits.

php artisan bookstack:regenerate-search

Docs update

  • Just a note on the feature mention in blogpost to re-index, does not really need to be an update advisory.

inv-hareesh and others added 5 commits February 7, 2025 08:59
This changes indexing so that a.b now indexes as "a", "b" AND "a.b"
instead of just the first two, for periods and hypens, so terms
containing those characters can be searched within.

Adds hypens as a delimiter - #2095
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Feb 14, 2025
@ssddanbrown ssddanbrown self-assigned this Feb 14, 2025
@ssddanbrown ssddanbrown merged commit 92ad814 into development Feb 14, 2025
10 of 17 checks passed
@ssddanbrown ssddanbrown deleted the search_index_updates branch February 14, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants