Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further Lexical Fixes #5415

Merged
merged 9 commits into from
Feb 16, 2025
Merged

Further Lexical Fixes #5415

merged 9 commits into from
Feb 16, 2025

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Jan 15, 2025 •
edited
Loading

Related to #5245

  • Adds additional test helpers and documentation.
  • Fixed issues with auto-url on space/enter, when at the end of a line.
  • Adds custom color select/management to color picker controls.
  • Adds color pickers to relevant form fields.
  • Adds table caption support.
  • Adds src conversions for YouTube urls via media insert.
  • Fixed error importing code blocks in some cases.

@ssddanbrown
Lexical: Fixed auto-link issue
0d1a237 
Added extra test helper to check the editor state directly via string
notation access rather than juggling types/objects to access deep
properties.
@ssddanbrown
Lexical: Added some general test guidance
7f5fd16 
Just to help remember the general layout/methods that we've added to
make testing easier.
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Jan 15, 2025
@ssddanbrown ssddanbrown self-assigned this Jan 15, 2025
@ssddanbrown
Lexical: Added color format custom color select
c091f67 
Includes tracking of selected colors via localstorage for display.
@ssddanbrown
Lexical: Added color picker/indicator to form fields
04cca77
@ssddanbrown
Lexical: Added support for table caption nodes
8a66365 
Needs linking up to the table form still.
@ssddanbrown
Lexical: Linked table form to have caption toggle option
958b537
@ssddanbrown
Lexical: Added media src conversions
d89a2fd 
Only actuall added YT in the end.
Google had changed URL scheme, and Vimeo seems to just be something else
now, can't really browse video pages like before.
@ssddanbrown
Lexical: Ran a deeper check on translation use
7e03a97
@ssddanbrown
Lexical: Fixed code in lists, removed extra old alignment code
2b74642 
Code in lists could throw error on parse due to inner <code> tag being
parsed but not actually used within a <pre>, so this updates the
importDOM to disregard childdren for code blocks.

This also improves the invariant implementation to not be so
dev/debugger based, and to include vars in the output.
@ssddanbrown ssddanbrown merged commit 213a86e into development Feb 16, 2025
7 of 11 checks passed
@ssddanbrown ssddanbrown deleted the more_lexical_fixes branch February 16, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
💻 Front-End 📝 WYSIWYG Editor
Milestone
Next Feature Release
Development

Successfully merging this pull request may close these issues.
1 participant
@ssddanbrown