You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Orientate the given intervention image based upon the given original image data.
* Intervention does have an `orientate` method but the exif data it needs is lost before it
* can be used (At least when created using binary string data) so we need to do some
* implementation on our side to use the original image data.
* Bulk of logic taken from: https://github.com/Intervention/image/blob/b734a4988b2148e7d10364b0609978a88d277536/src/Intervention/Image/Commands/OrientateCommand.php
This can now lead to images being wrongly rotated, due to changes in intervention 3 which would apply orientation by default, leading to the the orientation being applied double.
This is mentioned in the upgrade notes, but quite easy to miss which I did.
Somewhat related to some of the newer comments in #4875.
The text was updated successfully, but these errors were encountered:
We are specifically setting rotation based upon exif via our own custom means:
BookStack/app/Uploads/ImageResizer.php
Lines 178 to 186 in 387c786
This can now lead to images being wrongly rotated, due to changes in intervention 3 which would apply orientation by default, leading to the the orientation being applied double.
This is mentioned in the upgrade notes, but quite easy to miss which I did.
Somewhat related to some of the newer comments in #4875.
The text was updated successfully, but these errors were encountered: