Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partly missing coloring in code section #5078

Closed
TobiZog opened this issue Jun 24, 2024 · 1 comment
Closed

Partly missing coloring in code section #5078

TobiZog opened this issue Jun 24, 2024 · 1 comment

Comments

@TobiZog
Copy link

TobiZog commented Jun 24, 2024

Describe the Bug

In a code section (created with the markdown editor) are lines, which are not colored. In Markdown, all lines in the section are written in the same way.

Steps to Reproduce

I can't exactly tell, who this happened.

Expected Behaviour

Full colored source code

Screenshots or Additional Context

Result which I get:
2024-06-24_11-18

Source code:

<pre id="bkmrk-%3Cv-navigation-drawer"><code class="language-html">&lt;v-navigation-drawer&gt;
  &lt;v-list&gt;
    &lt;v-list-item title="My Application" subtitle="Vuetify" /&gt;
    &lt;v-divider /&gt;
    &lt;v-list-item link title="List Item 1"&gt;&lt;/v-list-item&gt;
    &lt;v-list-item link title="List Item 2"&gt;&lt;/v-list-item&gt;
    &lt;v-list-item link title="List Item 3"&gt;&lt;/v-list-item&gt;
  &lt;/v-list&gt;
&lt;/v-navigation-drawer&gt;
</code></pre>

Source code in Firefox's inspector:
image

It seems that the wrong colored lines are false packaged.

Browser Details

Firefox 127.0.1 on Linux Mint

Exact BookStack Version

v24.05.2

@ssddanbrown
Copy link
Member

Thanks for raising @TobiZog,
I found that the underlying highlighting library by default would not accept custom self-closing tags by default, but there was an option to enabled this which I have done in adb7bf7.

This change will be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants