Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating to header in Spoiler / collapsible blocks #4637

Closed
JK1198 opened this issue Oct 31, 2023 · 2 comments
Closed

Navigating to header in Spoiler / collapsible blocks #4637

JK1198 opened this issue Oct 31, 2023 · 2 comments
Labels
🐛 Bug 💻 Front-End
Milestone
v23.10.1

Comments

@JK1198
Copy link

JK1198 commented Oct 31, 2023

Describe the Bug

When you create an header in an collapsible block (spoiler) is is displayed in the page navigation.
If you click on it in the navigation, nothing happens.
If you open the spoiler manually and click on the header in the navigation, it jumps to the correct header.

But the URL always changes correctly e.g.: .../books/testbook/page/testpage#bkmrk-header-inside-block

Steps to Reproduce

  1. Create a page with a collapsible block and create a header in it.
  2. After saving the page click on the header in the page navigation.
  3. Nothing happens.

Expected Behaviour

I would expect the spoiler to open and jump to the correct header when clicked on in the navigation section. Or it should at least jump to the spoiler.

Screenshots or Additional Context

Example Page:
image
With open spoiler:
image

Browser Details

No response

Exact BookStack Version

v23.06.02, v23.08, v23.10
@ssddanbrown ssddanbrown added this to the v23.10.1 milestone Oct 31, 2023
@ssddanbrown
Copy link
Member

Thanks for reporting @JK1198,
Should be simple for us to open the block before scrolling and go to the correct location as expected.
Have assigned for the next patch release.

ssddanbrown added a commit that referenced this issue Nov 1, 2023
@ssddanbrown
Page JS: Improved block jumping and highlighting
38ac3c9 
- Updated anchor scroll change to open up details blocks if the target
  exists within.
- Updated highlighting and animation implementation to fix hardly visible highlighting.
- Removed old, now unused, handing of CM instances in details blocks.

Related to #4637.
@ssddanbrown
Copy link
Member

This has now been addressed as part of 38ac3c9, and will be part of v23.10.1.
Thanks again for reporting @JK1198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 💻 Front-End
Milestone
v23.10.1
Development

No branches or pull requests
2 participants
@ssddanbrown @JK1198