Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate gitignores #72

Open
grst opened this issue Dec 16, 2024 · 3 comments · May be fixed by #73
Open

consolidate gitignores #72

grst opened this issue Dec 16, 2024 · 3 comments · May be fixed by #73
Assignees
@grst

Comments

@grst
Copy link
Collaborator

grst commented Dec 16, 2024

Instead of having many gitignores in subfolders, it might be better to have a single one per stage.

Additionally, this solves an issue where the entire output directory couldn't be tracked by dvc because of overlapping paths.
@grst grst self-assigned this Dec 16, 2024
@grst grst linked a pull request Dec 17, 2024 that will close this issue
Open
@tschwarzl
Copy link
Contributor

regarding output overlapping path, one can add .dvcignore to the stage to ignore the output/.gitignore. This should resolve the conflict

@grst
Copy link
Collaborator Author

grst commented Jan 7, 2025 •
edited
Loading

still wondering if dso repro will remove the entire output directory if it is tracked as output, even if it contains a .gitignore tracked by git and excluded by dvcignore -- will check.

@grst
Copy link
Collaborator Author

grst commented Jan 8, 2025

@tschwarzl, I couldn't make it work with the .dvcignore. It still complained about output being tracked by git and it also keeps removing the entire directory.

I therefore re-opened #73 which moves the .gitignore outside the output directory.

Please let me know if you have another working solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grst grst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gitignores in stage template Boehringer-Ingelheim/dso
2 participants
@grst @tschwarzl