-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc issues (Feb 2019) #20
Comments
From: Kristin Brodeur [email protected] Ah, I did not realize that! I believe or don’t have spaces in our current tags. From: Teresa Elsey [email protected] I think including the space is more technically correct (doesn't matter on the web, but XML is more strict than HTML). Do we have other self-closing tags with no space? Plus you don't want to break your ebook on Netscape 4! From: Kristin Brodeur [email protected] And another minor thing—the tool spits out but could we possibly get it without the extra space (so it’s ) so my OCD side will be happier? :D From: Kristin Brodeur [email protected] Oh yeah, I also meant to mention the spaces in ellipses—they just come out as . . . in this tool, but I don’t love that because it’s impossible for me to tell if they’re actually non-breaking spaces or not… Would it be possible to have those spaces come out as ? From: Kristin Brodeur [email protected] #15 looks good to me! The only thing I’d mention is that the old tool would put “Chapter” in the leaf note bracket area, but that’s probably not even necessary since that’s not what we’d want in the TOC anyway, if it were going to pull from there. #12 didn’t work for me—the dedication still became just a regular paragraph in the copyright section. Other things I noticed when converting the AGATHA PARROT AND THE ODD STREET SCHOOL GHOST cxml— Thanks! From: Teresa Elsey [email protected] Let me know what you think on #12 and #15, and I'll ask Peter to work on the new issues/try to wrap this up! From: Teresa Elsey [email protected] Sorry, I see I have a note from you about #13! Will dig into it this week. From: Teresa Elsey [email protected] Hi, guys -- Peter's latest updates to typefi2bookxml are in -- I've posted version 0.9.1 in the usual place (digital managing ed > Teresa > Typefi2BookXML) Katie, could you check these two?
Kristin, it should be adding some basic leaf notes now (though see Peter's note below about copyright). Could you check that? Were you OK with my closing #13, Kristin? Peter's still working on #12. (Let me know how essential you think this is, KB?) I think you're good to use this for your real projects -- let me know if you encounter any new bugs, of course! Thanks! On 5/30/16, 10:52 PM, "Peter Fry" [email protected] wrote: Teresa, I posted the latest version of the app. I fixed everything except for the Dedication/Epigraph feature. I’m going to have to think on the best way to implement that. For the leaf notes, I think I have them all working except there’s really no good way to identify the ‘Copyright’ section of most of these samples if they have no title tag. Let me know if that matters. -peter |
From: Kristin Brodeur [email protected] Haha sorry, I discovered/remembered other things as I was working… Whoops, sorry, I had read that about #12 before but then forgot when I actually looked at the issues. I’d say it’d be nice to have but not a big deal. It’s easy enough for me to just manually adjust those. I was thinking that initially about maintaining the spaces from the cxml, but a lot, if not most, of the cxml I get has those things broken up across lines, like so: <tps:p type="Normal"> so I wouldn’t really want it to maintain that spacing… I feel like partially italicized words are much less frequent and should be easy enough to spot in QA, though, so maybe it’s OK if the default is to space those out? From: Teresa Elsey [email protected] OK, great, I'm closing #15. And yeah, re: #12, Peter didn't do any work on it -- he was having trouble figuring out the best way to do it. My question for you was just how important to you it is that he figure it out, on a scale of "nice to have but no big deal" to "totally essential." So I'll add "Art" to "Element" and "Figure holder" as things that should become s? Are there more? :-O Ugh, the thing. I started trying to write the logic for it and kept thinking of counterexamples (this is fanfreakingtastic!). I probably need Peter to go back and rewrite things so the tool keeps the spaces that are in the cXML, rather than closing everything up and then readding them. But that may have its own problems with things like how it fixes the spaces around dashes. (And while I was writing this you just sent me like three more issues!) Teresa From: Kristin Brodeur [email protected] #15 looks good to me! The only thing I’d mention is that the old tool would put “Chapter” in the leaf note bracket area, but that’s probably not even necessary since that’s not what we’d want in the TOC anyway, if it were going to pull from there. #12 didn’t work for me—the dedication still became just a regular paragraph in the copyright section. Other things I noticed when converting the AGATHA PARROT AND THE ODD STREET SCHOOL GHOST cxml— Thanks! From: Teresa Elsey [email protected] Let me know what you think on #12 and #15, and I'll ask Peter to work on the new issues/try to wrap this up! From: Teresa Elsey [email protected] Sorry, I see I have a note from you about #13! Will dig into it this week. From: Teresa Elsey [email protected] Hi, guys -- Peter's latest updates to typefi2bookxml are in -- I've posted version 0.9.1 in the usual place (digital managing ed > Teresa > Typefi2BookXML) Katie, could you check these two?
Kristin, it should be adding some basic leaf notes now (though see Peter's note below about copyright). Could you check that? Were you OK with my closing #13, Kristin? Peter's still working on #12. (Let me know how essential you think this is, KB?) I think you're good to use this for your real projects -- let me know if you encounter any new bugs, of course! Thanks! On 5/30/16, 10:52 PM, "Peter Fry" [email protected] wrote: Teresa, I posted the latest version of the app. I fixed everything except for the Dedication/Epigraph feature. I’m going to have to think on the best way to implement that. For the leaf notes, I think I have them all working except there’s really no good way to identify the ‘Copyright’ section of most of these samples if they have no title tag. Let me know if that matters. -peter |
From: Kristin Brodeur [email protected] The xml looks much better now! Visually, at least. Issue #3 still isn’t quite right yet, but I commented on that thread with notes. I did find a bunch of new things, though:
<tps:p type="SPCBRK1”/> is being converted to this: When it should be <break type=“space"/>. Could we also make the default for the next para after a space break to be left-aligned?
<tps:section id="F7ECBD02-B7AB-9743-A646-0C715D02DAA1" type="Chapter"> became this: <title>1</title> One So I think the tool is automatically adding in numerical chapter numbers from the [value=“1”] part, and then it doesn’t realize that the word “One” is actually supposed to be the title. I also tested one that had a CT tag, and this: <tps:section id="7EBD58FA-A73E-2F4D-9E24-195FCE201DA8" type="Chapter"> became this:
The Lake With an empty tag for some reason. That one has a chapter opening image right after, and there are some issues with that, too. The class before the title doesn’t close until after some of the text at the beginning of the chapter. So this is the full beginning of chapter 1: <tps:section id="7EBD58FA-A73E-2F4D-9E24-195FCE201DA8" type="Chapter"> and it becomes:
The Lake It was Martha who saw thelakeSo, first, we usually have the fig id first, before the filename (not sure if that actually matters), and it should be a self-closing tag, without . Then the tag before the tag in the 3rd line should move down to after the image, and the tag and corresponding tag (after “saw the”) shouldn’t be there at all (and I don’t really know why the tool produced them).
<tps:p type="EXT2"> to this: When [my students] moved from the mountain because of the park, the older ones went to work and the younger ones found their places in the regular schools where they moved. I often wonder what their lot would have been if they had not had all this preparation before leaving their mountain. Because of the school, they were able to take their place in a normal way and many have done very well and have nice homes and fine families of their own today. Can we remove the redundant extra tags? And maybe make the a (though I can manually change that, so it’s not a huge deal)? That seems like plenty for now… :) Kristin From: Teresa Elsey [email protected] Thanks, guys! Version 5 (there is no version 4) is up on Box now (Teresa > Typefi2BookXML). Kristin, could you check the fix to #3 and close it if it's OK? For both of you -- I think Peter made good progress on #1 (removing whitespace to make the XML more readable), but I spotted a couple bugs (spaces removed where they shouldn't have been). Would you each try some of your cXML and see if you can spot any more? (You can add comments for the bugs if you do, and post samples on Box for Peter if they're from titles he won't have.) You can also try converting your resultant XML to epub (I found it easier to spot spacing errors that way, and you can also see what additional errors are generated in that process). Not a huge rush on this -- I'll plan to check in with Peter again when I'm back on Wednesday, I think. Thanks! From: Katie Coaster [email protected] I don’t think we are allowed to close without it being assigned to us? But both of mine are good to go—the link handling looks great. From: Teresa Elsey [email protected] Hi, guys -- Peter has delivered version 3 of the Typefi2BookXML tool. You'll find it in my Box: Teresa > Typefi2BookXML. Can you guys help with testing the fixes in this version? The GitHub repo is here: Could you each take a look at the following issues in the next day or two? If they're fine, you can comment and close; let me know if they need more explanation or further testing. Katie: #8, #7 Thanks! |
Dumping a series of issues from my email here. (I think they are unresolved, but I'm not sure.)
--
From: Kristin Brodeur [email protected]
Date: Monday, September 12, 2016 at 9:28 AM
To: "Elsey, Teresa" [email protected]
Subject: Things to add to the cxml converter
Hi!
GIRLS LIKE ME had some strikethrough text, and it came through somewhat (as in, it wasn’t erased) but it would be nice if it came through as the correct emph type instead.
In cxml:
<tps:style type="strikethrough">
Kids
</tps:style>
In xml:
<style type="strikethrough"> Kids </style>The actual emph type is . Just figured I’d mention!
Thanks,
Kristin
--
From: Kristin Brodeur [email protected]
Date: Thursday, June 9, 2016 at 3:03 PM
To: "Elsey, Teresa" [email protected]
Subject: Re: Another cxml thing
Me again, since I know you love getting lots of emails about cxml things!
Can we make the tool translate double/single quote combinations so there’s no space in between?
So,
“‘
instead of
“ ‘
(not that you can tell the difference that much there) and the same for the closing quotes?
From: Kristin Brodeur [email protected]
Date: Thursday, June 9, 2016 at 12:15 PM
To: Teresa Elsey [email protected]
Subject: Another cxml thing
Hey Teresa,
In the xml that came out for MIRAGE, all the paras in the Acknowledgments section at the end came out as
but I just want the first one to be left, and the rest to be regular
s. The cxml and xml from the tool are in my Box folder in cxml test.
Thanks!
Kristin
--
The text was updated successfully, but these errors were encountered: