Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc issues (Feb 2019) #20

Open
teresaelsey opened this issue Feb 12, 2019 · 3 comments
Open

Misc issues (Feb 2019) #20

teresaelsey opened this issue Feb 12, 2019 · 3 comments

Comments

@teresaelsey
Copy link
Collaborator

Dumping a series of issues from my email here. (I think they are unresolved, but I'm not sure.)

--
From: Kristin Brodeur [email protected]
Date: Monday, September 12, 2016 at 9:28 AM
To: "Elsey, Teresa" [email protected]
Subject: Things to add to the cxml converter

Hi!

GIRLS LIKE ME had some strikethrough text, and it came through somewhat (as in, it wasn’t erased) but it would be nice if it came through as the correct emph type instead.

In cxml:

<tps:style type="strikethrough">
Kids
</tps:style>

In xml:

<style type="strikethrough"> Kids </style>

The actual emph type is . Just figured I’d mention!

Thanks,
Kristin

--

From: Kristin Brodeur [email protected]
Date: Thursday, June 9, 2016 at 3:03 PM
To: "Elsey, Teresa" [email protected]
Subject: Re: Another cxml thing

Me again, since I know you love getting lots of emails about cxml things!

Can we make the tool translate double/single quote combinations so there’s no space in between?

So,

“‘

instead of

“ ‘

(not that you can tell the difference that much there) and the same for the closing quotes?

From: Kristin Brodeur [email protected]
Date: Thursday, June 9, 2016 at 12:15 PM
To: Teresa Elsey [email protected]
Subject: Another cxml thing

Hey Teresa,

In the xml that came out for MIRAGE, all the paras in the Acknowledgments section at the end came out as

but I just want the first one to be left, and the rest to be regular

s. The cxml and xml from the tool are in my Box folder in cxml test.

Thanks!
Kristin

--

@teresaelsey
Copy link
Collaborator Author

From: Kristin Brodeur [email protected]
Date: Tuesday, June 7, 2016 at 4:39 PM
To: "Elsey, Teresa" [email protected]
Subject: Re: typefi2bookxml 0.9.1

Ah, I did not realize that!

I believe or don’t have spaces in our current tags.

From: Teresa Elsey [email protected]
Date: Tuesday, June 7, 2016 at 4:37 PM
To: Kristin Brodeur [email protected]
Subject: Re: typefi2bookxml 0.9.1

I think including the space is more technically correct (doesn't matter on the web, but XML is more strict than HTML). Do we have other self-closing tags with no space?

Plus you don't want to break your ebook on Netscape 4!
http://stackoverflow.com/questions/462741/space-before-closing-slash

From: Kristin Brodeur [email protected]
Date: Tuesday, June 7, 2016 at 4:12 PM
To: Teresa Elsey [email protected]
Subject: Re: typefi2bookxml 0.9.1

And another minor thing—the tool spits out but could we possibly get it without the extra space (so it’s ) so my OCD side will be happier?

:D

From: Kristin Brodeur [email protected]
Date: Tuesday, June 7, 2016 at 4:10 PM
To: Teresa Elsey [email protected]
Subject: Re: typefi2bookxml 0.9.1

Oh yeah, I also meant to mention the spaces in ellipses—they just come out as . . . in this tool, but I don’t love that because it’s impossible for me to tell if they’re actually non-breaking spaces or not… Would it be possible to have those spaces come out as   ?

From: Kristin Brodeur [email protected]
Date: Tuesday, June 7, 2016 at 3:06 PM
To: Teresa Elsey [email protected]
Subject: Re: typefi2bookxml 0.9.1

#15 looks good to me! The only thing I’d mention is that the old tool would put “Chapter” in the leaf note bracket area, but that’s probably not even necessary since that’s not what we’d want in the TOC anyway, if it were going to pull from there.

#12 didn’t work for me—the dedication still became just a regular paragraph in the copyright section.

Other things I noticed when converting the AGATHA PARROT AND THE ODD STREET SCHOOL GHOST cxml—
• This cxml had images labeled as “Art”—the tool translated them correctly to <fig id…> but without the tags.
• When tags appear next to punctuation, there’s a space between the punctuation and the tag at either end (presumably because of his adjustments to make sure there is space between words or ends of sentences). Can we make it so the tool reads the context? i.e., No space between quotes and tags, or a closing tag and a comma/period/semicolon, or next to em dashes, but a space between letters and tags? The old tool seemed to be able to do that.
The cxml and xml files are in my Box folder with the other cxml tests.

Thanks!
Kristin

From: Teresa Elsey [email protected]
Date: Monday, June 6, 2016 at 10:55 AM
To: Kristin Brodeur [email protected]
Subject: Re: typefi2bookxml 0.9.1

Let me know what you think on #12 and #15, and I'll ask Peter to work on the new issues/try to wrap this up!
Teresa

From: Teresa Elsey [email protected]
Date: Tuesday, May 31, 2016 at 5:18 PM
To: Kristin Brodeur [email protected]
Subject: Re: typefi2bookxml 0.9.1

Sorry, I see I have a note from you about #13! Will dig into it this week.

From: Teresa Elsey [email protected]
Date: Tuesday, May 31, 2016 at 1:41 PM
To: Katie Coaster [email protected], Kristin Brodeur [email protected]
Subject: FW: typefi2bookxml 0.9.1

Hi, guys --

Peter's latest updates to typefi2bookxml are in -- I've posted version 0.9.1 in the usual place (digital managing ed > Teresa > Typefi2BookXML)

Katie, could you check these two?

Kristin, it should be adding some basic leaf notes now (though see Peter's note below about copyright). Could you check that?
#15

Were you OK with my closing #13, Kristin?
#13

Peter's still working on #12. (Let me know how essential you think this is, KB?)

I think you're good to use this for your real projects -- let me know if you encounter any new bugs, of course!

Thanks!
Teresa

On 5/30/16, 10:52 PM, "Peter Fry" [email protected] wrote:

Teresa,

I posted the latest version of the app. I fixed everything except for the Dedication/Epigraph feature. I’m going to have to think on the best way to implement that. For the leaf notes, I think I have them all working except there’s really no good way to identify the ‘Copyright’ section of most of these samples if they have no title tag. Let me know if that matters.

-peter

@teresaelsey
Copy link
Collaborator Author

From: Kristin Brodeur [email protected]
Date: Tuesday, June 7, 2016 at 4:24 PM
To: "Elsey, Teresa" [email protected]
Subject: Re: typefi2bookxml 0.9.1

Haha sorry, I discovered/remembered other things as I was working…

Whoops, sorry, I had read that about #12 before but then forgot when I actually looked at the issues. I’d say it’d be nice to have but not a big deal. It’s easy enough for me to just manually adjust those.

I was thinking that initially about maintaining the spaces from the cxml, but a lot, if not most, of the cxml I get has those things broken up across lines, like so:

<tps:p type="Normal">
tps:t/
<tps:c type="italics">

</tps:c>
<tps:style type="italic">
Loo tong?
</tps:style>
<tps:c type="italics">

</tps:c>
tps:s/
we said.
</tps:p>

so I wouldn’t really want it to maintain that spacing… I feel like partially italicized words are much less frequent and should be easy enough to spot in QA, though, so maybe it’s OK if the default is to space those out?

From: Teresa Elsey [email protected]
Date: Tuesday, June 7, 2016 at 4:20 PM
To: Kristin Brodeur [email protected]
Subject: Re: typefi2bookxml 0.9.1

OK, great, I'm closing #15.

And yeah, re: #12, Peter didn't do any work on it -- he was having trouble figuring out the best way to do it. My question for you was just how important to you it is that he figure it out, on a scale of "nice to have but no big deal" to "totally essential."

So I'll add "Art" to "Element" and "Figure holder" as things that should become s? Are there more? :-O

Ugh, the thing. I started trying to write the logic for it and kept thinking of counterexamples (this is fanfreakingtastic!). I probably need Peter to go back and rewrite things so the tool keeps the spaces that are in the cXML, rather than closing everything up and then readding them. But that may have its own problems with things like how it fixes the spaces around dashes.

(And while I was writing this you just sent me like three more issues!)

Teresa

From: Kristin Brodeur [email protected]
Date: Tuesday, June 7, 2016 at 3:06 PM
To: Teresa Elsey [email protected]
Subject: Re: typefi2bookxml 0.9.1

#15 looks good to me! The only thing I’d mention is that the old tool would put “Chapter” in the leaf note bracket area, but that’s probably not even necessary since that’s not what we’d want in the TOC anyway, if it were going to pull from there.

#12 didn’t work for me—the dedication still became just a regular paragraph in the copyright section.

Other things I noticed when converting the AGATHA PARROT AND THE ODD STREET SCHOOL GHOST cxml—
• This cxml had images labeled as “Art”—the tool translated them correctly to <fig id…> but without the tags.
• When tags appear next to punctuation, there’s a space between the punctuation and the tag at either end (presumably because of his adjustments to make sure there is space between words or ends of sentences). Can we make it so the tool reads the context? i.e., No space between quotes and tags, or a closing tag and a comma/period/semicolon, or next to em dashes, but a space between letters and tags? The old tool seemed to be able to do that.
The cxml and xml files are in my Box folder with the other cxml tests.

Thanks!
Kristin

From: Teresa Elsey [email protected]
Date: Monday, June 6, 2016 at 10:55 AM
To: Kristin Brodeur [email protected]
Subject: Re: typefi2bookxml 0.9.1

Let me know what you think on #12 and #15, and I'll ask Peter to work on the new issues/try to wrap this up!
Teresa

From: Teresa Elsey [email protected]
Date: Tuesday, May 31, 2016 at 5:18 PM
To: Kristin Brodeur [email protected]
Subject: Re: typefi2bookxml 0.9.1

Sorry, I see I have a note from you about #13! Will dig into it this week.

From: Teresa Elsey [email protected]
Date: Tuesday, May 31, 2016 at 1:41 PM
To: Katie Coaster [email protected], Kristin Brodeur [email protected]
Subject: FW: typefi2bookxml 0.9.1

Hi, guys --

Peter's latest updates to typefi2bookxml are in -- I've posted version 0.9.1 in the usual place (digital managing ed > Teresa > Typefi2BookXML)

Katie, could you check these two?

Kristin, it should be adding some basic leaf notes now (though see Peter's note below about copyright). Could you check that?
#15

Were you OK with my closing #13, Kristin?
#13

Peter's still working on #12. (Let me know how essential you think this is, KB?)

I think you're good to use this for your real projects -- let me know if you encounter any new bugs, of course!

Thanks!
Teresa

On 5/30/16, 10:52 PM, "Peter Fry" [email protected] wrote:

Teresa,

I posted the latest version of the app. I fixed everything except for the Dedication/Epigraph feature. I’m going to have to think on the best way to implement that. For the leaf notes, I think I have them all working except there’s really no good way to identify the ‘Copyright’ section of most of these samples if they have no title tag. Let me know if that matters.

-peter

@teresaelsey
Copy link
Collaborator Author

From: Kristin Brodeur [email protected]
Date: Friday, April 15, 2016 at 12:27 PM
To: "Elsey, Teresa" [email protected], Katie Coaster [email protected]
Subject: Re: New version of Typefi2BookXML

The xml looks much better now! Visually, at least. Issue #3 still isn’t quite right yet, but I commented on that thread with notes.

I did find a bunch of new things, though:

  1. This:

<tps:p type="SPCBRK1”/>

is being converted to this:

When it should be <break type=“space"/>. Could we also make the default for the next para after a space break to be left-aligned?

  1. In the copyright section of the front matter, can we make it so anything with a <tps:p type="Copyright (space above)”> or <tps:p type="Copyright”> tag becomes centered, instead of just

    ?

  2. The dedication just became a

    tag within the copyright section, rather than its own section

  3. Chapter numbers/titles aren’t coming through right. This:

<tps:section id="F7ECBD02-B7AB-9743-A646-0C715D02DAA1" type="Chapter">
<tps:context id="60286C90-7380-B64E-B8C8-B38D1CDDCCFC" type="CN">
<tps:fieldSet name="CN" value="1"/>
<tps:p type="CN">
One
</tps:p>
</tps:context>

became this:

<title>1</title>

One

So I think the tool is automatically adding in numerical chapter numbers from the [value=“1”] part, and then it doesn’t realize that the word “One” is actually supposed to be the title. I also tested one that had a CT tag, and this:

<tps:section id="7EBD58FA-A73E-2F4D-9E24-195FCE201DA8" type="Chapter">
<tps:fieldSet name="Chapter number" value="1"/>
<tps:p type="Normal">
<tps:c type="Italic">
<tps:context id="D4AB0696-0DEC-AA46-A889-69E35ADAAE54" type="CT">
<tps:p type="CT">
The Lake
</tps:p>
</tps:context>

became this:


<title>1</title>

The Lake

With an empty tag for some reason. That one has a chapter opening image right after, and there are some issues with that, too. The class before the title doesn’t close until after some of the text at the beginning of the chapter. So this is the full beginning of chapter 1:

<tps:section id="7EBD58FA-A73E-2F4D-9E24-195FCE201DA8" type="Chapter">
<tps:fieldSet name="Chapter number" value="1"/>
<tps:p type="Normal">
<tps:c type="Italic">
<tps:context id="D4AB0696-0DEC-AA46-A889-69E35ADAAE54" type="CT">
<tps:p type="CT">
The Lake
</tps:p>
</tps:context>
<tps:context id="B57EFBB7-D76A-D742-AC76-CDF6DF15C22F" type="Element">
<tps:image ref="../Images/Magic Lake_page 1.tif"/>
</tps:context>
It was Martha who saw the
tps:s/
</tps:c>
<tps:style type="bold|italic">
lake
</tps:style>

and it becomes:


<title>1</title>

The Lake

It was Martha who saw thelake

So, first, we usually have the fig id first, before the filename (not sure if that actually matters), and it should be a self-closing tag, without . Then the

tag before the tag in the 3rd line should move down to after the image, and the tag and corresponding tag (after “saw the”) shouldn’t be there at all (and I don’t really know why the tool produced them).

  1. An EXT2 tag was converted from:

<tps:p type="EXT2">
When [my students] moved from the mountain because of the park, the older ones went to work and the younger ones found their places in the regular schools where they moved. I often wonder what their lot would have been if they had not had all this preparation before leaving their mountain. Because of the school, they were able to take their place in a normal way and many have done very well and have nice homes and fine families of their own today.
</tps:p>

to this:

When [my students] moved from the mountain because of the park, the older ones went to work and the younger ones found their places in the regular schools where they moved. I often wonder what their lot would have been if they had not had all this preparation before leaving their mountain. Because of the school, they were able to take their place in a normal way and many have done very well and have nice homes and fine families of their own today.


Can we remove the redundant extra

tags? And maybe make the

a

(though I can manually change that, so it’s not a huge deal)?

That seems like plenty for now… :)

Kristin

From: Teresa Elsey [email protected]
Date: Friday, April 15, 2016 at 10:41 AM
To: Katie Coaster [email protected], Kristin Brodeur [email protected]
Subject: Re: New version of Typefi2BookXML

Thanks, guys!

Version 5 (there is no version 4) is up on Box now (Teresa > Typefi2BookXML).

Kristin, could you check the fix to #3 and close it if it's OK?

For both of you -- I think Peter made good progress on #1 (removing whitespace to make the XML more readable), but I spotted a couple bugs (spaces removed where they shouldn't have been). Would you each try some of your cXML and see if you can spot any more? (You can add comments for the bugs if you do, and post samples on Box for Peter if they're from titles he won't have.)

You can also try converting your resultant XML to epub (I found it easier to spot spacing errors that way, and you can also see what additional errors are generated in that process).

Not a huge rush on this -- I'll plan to check in with Peter again when I'm back on Wednesday, I think.

Thanks!
Teresa

From: Katie Coaster [email protected]
Date: Tuesday, April 12, 2016 at 11:56 AM
To: Teresa Elsey [email protected], Kristin Brodeur [email protected]
Subject: Re: New version of Typefi2BookXML

I don’t think we are allowed to close without it being assigned to us? But both of mine are good to go—the link handling looks great.

From: Teresa Elsey [email protected]
Date: Tuesday, April 12, 2016 at 11:03 AM
To: Katie Coaster [email protected], Kristin Brodeur [email protected]
Subject: New version of Typefi2BookXML

Hi, guys --

Peter has delivered version 3 of the Typefi2BookXML tool. You'll find it in my Box: Teresa > Typefi2BookXML.

Can you guys help with testing the fixes in this version?

The GitHub repo is here:
https://github.com/BoboFraggins/typefi2bookxml/issues

Could you each take a look at the following issues in the next day or two? If they're fine, you can comment and close; let me know if they need more explanation or further testing.

Katie: #8, #7
Teresa: #5, #4
Kristin: #3, #1

Thanks!
Teresa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant