archive: add managed flag

used to specify archives that support deleting/iterating files, required for archive cmd

Author: MarcKe

Diff for: doc/manpages/bob-archive.rst

@@ -32,9 +32,10 @@ Description
 -----------
 
 The bob archive command can be used to manage binary artifact archives.
-The command works on the archives defined in the user configuration :ref:`archive <configuration-config-archive>`.
-The archives to work on need to be specified (`-l`, `-a`, `-b`).
-It needs write access to the recipe root folder to create an index cache.
+The command works on the archives defined in the user configuration :ref:`archive <configuration-config-archive>` .
+The archives require the `managed` flag.
+The archives to work on need to be explicitly specified (`-l`, `-a`, `-b`).
+Write access to the recipe root folder to create an index cache is required.
 
 Artifacts are managed by the information included in their :ref:`Audit Trail
 <audit-trail>`. See the Audit Trail documentation for a detailed description of

Diff for: doc/manual/configuration.rst

@@ -2233,7 +2233,9 @@ The default is ``[download, upload]``.
 ``upload``
     Use this archive to upload artifacts. To actually upload to the archive the
     build must be performed with uploads enabled (``--upload``).
-
+``managed``
+    This archive is managed, meaning the files can be iterated and deleted.
+    This is required for the archive command to work.
 ``cache``
     Use this archive to cache downloaded artifacts from other archives. If a
     binary artifact was successfully downloaded from another archive it will

Diff for: pym/bob/archive.py

@@ -365,6 +365,7 @@ def __init__(self, spec):
         self.__useLocal = "nolocal" not in flags
         self.__useJenkins = "nojenkins" not in flags
         self.__useCache = "cache" in flags
+        self.__managed = "managed" in flags
         self.__wantDownloadLocal = False
         self.__wantDownloadJenkins = False
         self.__wantUploadLocal = False
@@ -401,6 +402,9 @@ def _openDownloadFile(self, buildId, suffix):
         raise ArtifactNotFoundError()
 
     def canManage(self):
+        return self.__managed and self._canManage()
+
+    def _canManage(self):
         return False
 
     async def downloadPackage(self, step, buildId, audit, content, caches=[],
@@ -754,7 +758,7 @@ def __init__(self, spec):
         self.__fileMode = spec.get("fileMode")
         self.__dirMode = spec.get("directoryMode")
 
-    def canManage(self):
+    def _canManage(self):
         return True
 
     def _getPath(self, buildId, suffix):
@@ -879,7 +883,7 @@ def __retry(self, request):
                 if not retry: return (False, e)
                 retry = False
 
-    def canManage(self):
+    def _canManage(self):
         return True
 
     def _resetConnection(self):

Diff for: pym/bob/cmds/archive.py

@@ -516,7 +516,7 @@ def doArchive(argv, bobRoot):
     archivers = []
     if args.local:
         # provide local directory as backend
-        archivespec = [{"name" : "local", "backend": "file", "path": "{}".format(os.getcwd())}]
+        archivespec = [{"name" : "local", "backend": "file", "path": "{}".format(os.getcwd()), "flags" : "[download, upload, managed]"}]
         archiver = getSingleArchiver(None, archivespec[0])
         archivers.append(archiver)
     else:

Diff for: pym/bob/input.py

@@ -2984,7 +2984,7 @@ def __init__(self):
         baseArchive = {
             'backend' : str,
             schema.Optional('name') : str,
-            schema.Optional('flags') : schema.Schema(["download", "upload",
+            schema.Optional('flags') : schema.Schema(["download", "upload", "managed",
                 "nofail", "nolocal", "nojenkins", "cache"])
         }
         fileArchive = baseArchive.copy()

Diff for: test/black-box/archive/run.sh

@@ -17,13 +17,15 @@ archive:
     name: "local"
     backend: file
     path: "$(mangle_path "$archiveDir")"
+    flags: [download, upload, managed]
 EOF
   if [[ "$1" == "multi" ]]; then
     cat >> default.yaml << EOF
   -
     name: "local2"
     backend: file
     path: "$(mangle_path "$archiveDir2")"
+    flags: [download, upload, managed]
 EOF
   fi
 }