perf: 组件代码优化

BoBoooooo · Dec 7, 2020 · 4023818 · 4023818
1 parent c1aed5a
commit 4023818
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/packages/form-designer/src/FormDesignerDialog.vue b/packages/form-designer/src/FormDesignerDialog.vue
@@ -200,10 +200,11 @@
           </td>
         </tbody>
       </table>
-      <el-button type="success"
-                 @click="handleGenerateKey(true)">自动生成表单(根据数据库字段初始化,默认一行两列)</el-button>
-      <!-- <el-button type="primary"
-                   @click="handleGenerateKey()">自动绑定key(已有表单的情况)</el-button> -->
+      <el-tooltip title="根据数据库字段初始化,默认一行两列">
+        <el-button type="success"
+                 style="float: right"
+                 @click="handleGenerateKey(true)">自动生成表单</el-button>
+      </el-tooltip>
     </cus-dialog>
   </el-container>
     </el-dialog>

diff --git a/packages/form-designer/src/GenerateForm.vue b/packages/form-designer/src/GenerateForm.vue
@@ -11,11 +11,11 @@
 <template>
   <div class="table-form-wrapper">
     <el-form ref="generateForm"
-             :class='{"table-form":data.config.isTableClass}'
+             :class='{"table-form": data.config && data.config.isTableClass}'
              :model="models"
              :rules="rules"
-             :label-position="data.config.labelPosition"
-             :label-width="data.config.labelWidth?data.config.labelWidth+ 'px':'140px'"
+             :label-position="data.config && data.config.labelPosition"
+             :label-width="data.config && data.config.labelWidth?data.config.labelWidth+ 'px':'140px'"
              size="small">
       <!-- 遍历从父组件传入的data，data下有list和config两个属性，list下的每个对象是表示一行组件的集合 -->
       <template v-for="item in this.data.list">
@@ -226,8 +226,10 @@ export default class GenerateForm extends Vue {
   tableSelections: any = {};
 
   created() {
-    // 根据数据结构生成给子组件的数据源
-    this.generateModle(this.data.list);
+    if (this.data.list) {
+      // 根据数据结构生成给子组件的数据源
+      this.generateModle(this.data.list);
+    }
   }
 
   getTableSelection($event, item) {

diff --git a/packages/form-designer/src/GenerateFormItem.vue b/packages/form-designer/src/GenerateFormItem.vue
@@ -397,7 +397,8 @@ export default class GenerateFormItem extends Vue {
   created() {
     this.initData();
     if (this.widget.type === 'table') {
-      this.$EventBus.$on(`refresh:subTable:${this.widget.model}`, () => {
+      // eslint-disable-next-line no-unused-expressions
+      this.$EventBus && this.$EventBus.$on(`refresh:subTable:${this.widget.model}`, () => {
         this.$refs.table.tableReload();
       });
     }
@@ -690,7 +691,8 @@ export default class GenerateFormItem extends Vue {
   }
 
   beforeDestroy() {
-    this.$EventBus.$off(`refresh:subTable:${this.widget.model}`);
+    // eslint-disable-next-line no-unused-expressions
+    this.$EventBus && this.$EventBus.$off(`refresh:subTable:${this.widget.model}`);
   }
 
   @Watch('dataModel')