Ajout de son nom de naissance #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible de le réecrire de la manière du commit ce0e581 ? Merci beaucoup pour ta PR ! |
js/correct.js
Outdated
| @@ -7,7 +7,8 @@ while(textNode=walk.nextNode()) { | |||
| 'Monsieur le Président|'+ | |||
| 'Président de la République française|'+ | |||
| 'Président de la République' + | |||
There was a problem hiding this comment.
Il manque le pipe final pour signifier les différentes options, de même qu'a la ligne suivante pour le nom complet de Manu.
There was a problem hiding this comment.
C'est exact, oubli de ma part. C'est corrigé.
|
Parfait, merci beaucoup ! |
js/correct.js
Outdated
| @@ -8,7 +8,7 @@ while(textNode=walk.nextNode()) { | |||
| 'Président de la République française|'+ | |||
| 'Président de la République|' + | |||
| 'Emmanuel Jean-Michel Frédéric Macron|', | |||
There was a problem hiding this comment.
Désolé de rouvrir, mais ça marche avec la virgule au lieu du + ?
There was a problem hiding this comment.
C'était une bien belle erreur, corrigée dans #11 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.