Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which deterministic scheme is being used #3

Open
hoxxep opened this issue Nov 26, 2024 · 0 comments
Open

Clarify which deterministic scheme is being used #3

hoxxep opened this issue Nov 26, 2024 · 0 comments

Comments

@hoxxep
Copy link

hoxxep commented Nov 26, 2024

Hello, judging by the code1 this repo follows the RFC 8949 4.2.1 spec for map key ordering (bytewise lexicographic). It's a little ambiguous, as the spec also includes the 4.2.3 backwards compatible scheme (length-first).

I've run into the same confusion with ciborium recently, and have been writing a PR enarx/ciborium#143 there to make the difference between the two flavours more obvious. I noticed cbor.me used dCBOR but didn't make it obvious which canonicalization scheme was being used.

Perhaps it would be helpful if it could be made more clear in the README or docs somewhere?

Cheers,
Liam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant