Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init function not guarded enough - Low Risk #73

Open
olahfemi opened this issue Mar 26, 2023 · 0 comments
Open

Init function not guarded enough - Low Risk #73

olahfemi opened this issue Mar 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@olahfemi
Copy link
Collaborator

olahfemi commented Mar 26, 2023

Description
The init function is not guarded enough which can cause a random user to interract with it and set a malicious diamond address before the authorised user implement the init function which can lead to loss of power an attacker.

Context:
DAOToken.sol SLOC 106

Recommendation
since the contract has the owner being set at the deployment, the init function is advisable to be guided for only an autourised owner to trigger the function.

@olahfemi olahfemi added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants