Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No code reuse - Low Risk #70

Open
olahfemi opened this issue Mar 26, 2023 · 0 comments
Open

No code reuse - Low Risk #70

olahfemi opened this issue Mar 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@olahfemi
Copy link
Collaborator

Description
The DAOToken contract inherits the IERC20 interface and reimplements already existing and battle-tested implementations of the ERC20 standard. Lack of code reuse can introduce subtle errors into the contract.

Context
DAOToken.sol

Recommendation
Use already battle-tested existing implementations of the ERC20 standard. Openzeppelin has an industry trusted and battle-tested ERC20 implementation.

@olahfemi olahfemi added the bug Something isn't working label Mar 26, 2023
@olahfemi olahfemi changed the title No Code reuse - Low Risk No code reuse - Low Risk Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants