Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid state override - Low Risk #69

Open
olahfemi opened this issue Mar 26, 2023 · 0 comments
Open

Invalid state override - Low Risk #69

olahfemi opened this issue Mar 26, 2023 · 0 comments
Assignees
@casweeney @developeruche
Labels
bug Something isn't working

Comments

@olahfemi
Copy link
Collaborator

Description
payFee does not check if the msg.sender is a former student in a previous cohort before updating the StudentDetails of msg.sender. This can occur if an address is included in the merkleProofs of the two cohorts.

Context
PreCertificateToken.sol SLOC 91

Recommendation
We recommend that payFee check if an address is an old student before updating its StudentDetails.
@olahfemi olahfemi added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casweeney casweeney

@developeruche developeruche

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olahfemi @casweeney @developeruche