Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameter - Medium Severity #63

Open
olahfemi opened this issue Mar 26, 2023 · 0 comments
Open

Unused parameter - Medium Severity #63

olahfemi opened this issue Mar 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@olahfemi
Copy link
Collaborator

Description
The function enforceNotBlacklisted(address _addr) an internal function takes in an address but used msg.sender and did not implement the parameter that was used, this could lead to the owner passing in a blacklisted address to the function mint_pre_certificate_token(address _to) and still successfully mint to a blacklisted address.

Context
LibDiamond.sol SLOC 232

Recommendation
The function should be readjusted to to make use of the address that was passed in the parameter as a check against blacklisted address.

@olahfemi olahfemi added the bug Something isn't working label Mar 26, 2023
@olahfemi olahfemi changed the title Unused parameter - Medium Risk Unused parameter - Medium Severity Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants