Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of Proposal to get cancelled before creation - Medium Severity #61

Open
olahfemi opened this issue Mar 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@olahfemi
Copy link
Collaborator

Description
The proposalcancel() function can allow an admin to cancel a proposalId before creation of such proposal, as there are no check to confirm that an IdPropsal have actually been proposed before giving the authourity to admin to cancel it, this implies that if an Admin mistakenly pass an Id which does not exist in the proposal for cancellation, the proposal will get cancel ahead of creating such proposal.

Context
GovernanceFacet.sol

Recommendation
Check that an Id proposal have actually been created before allowing cancellation because a proposal that has been cancelled cannot be revoked as there is no provision for a cancel proposal to be active anymore.

@olahfemi olahfemi added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants