You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The proposalcancel() function can allow an admin to cancel a proposalId before creation of such proposal, as there are no check to confirm that an IdPropsal have actually been proposed before giving the authourity to admin to cancel it, this implies that if an Admin mistakenly pass an Id which does not exist in the proposal for cancellation, the proposal will get cancel ahead of creating such proposal.
Recommendation
Check that an Id proposal have actually been created before allowing cancellation because a proposal that has been cancelled cannot be revoked as there is no provision for a cancel proposal to be active anymore.
The text was updated successfully, but these errors were encountered:
Description
The proposalcancel() function can allow an admin to cancel a proposalId before creation of such proposal, as there are no check to confirm that an IdPropsal have actually been proposed before giving the authourity to admin to cancel it, this implies that if an Admin mistakenly pass an Id which does not exist in the proposal for cancellation, the proposal will get cancel ahead of creating such proposal.
Context
GovernanceFacet.sol
Recommendation
Check that an Id proposal have actually been created before allowing cancellation because a proposal that has been cancelled cannot be revoked as there is no provision for a cancel proposal to be active anymore.
The text was updated successfully, but these errors were encountered: