Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check - Medium Severity #60

Open
olahfemi opened this issue Mar 26, 2023 · 0 comments
Open

Sanity check - Medium Severity #60

olahfemi opened this issue Mar 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@olahfemi
Copy link
Collaborator

Description:
function setUp() which initialise the super user is not guided from being called by normal users, even thou this function can only be called once, it can be forgotten by the deployer and smart users can triggers the function earlier than the authorised users and the lost of this control leads to the lost of total control of the protocol.

Context:
AccessControlFacet.sol SLOC10.

Recommendation:
it should be treated with carefulness after deployment by calling the init function right after deployment to avoid other unrecognised account calling the function or add a check of who can call the function to secure the setUp() function.

@olahfemi olahfemi added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants