Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing cmake INSTALL target #232

Closed
T-Jin opened this issue Jan 9, 2018 · 2 comments
Closed

missing cmake INSTALL target #232

T-Jin opened this issue Jan 9, 2018 · 2 comments

Comments

@T-Jin
Copy link
Contributor

T-Jin commented Jan 9, 2018

Cmake INSTALL target doesn't actually install built sc2api libs to CMAKE_INSTALL_PREFIX location.
Dependent libs (like protobuf and civetweb) does get copied over, but not sc2api.lib, ac2lib.lib, etc.

Is this intended behavior? Add the install target to cmakelist inside ./src?

Tested on win10 x64 with vs2017
@alkurbatov
Copy link
Contributor

Hi @T-Jin .
It had been implemented by @kuzi117 about a month ago, see #206

@T-Jin
Copy link
Contributor Author

T-Jin commented Jan 9, 2018

Cool. Hope the fix get merged soon.

@T-Jin T-Jin closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alkurbatov @T-Jin