Add more query tests #27

sweep-ai · 2023-11-01T19:01:33Z

PR Feedback: 👎

Description

This PR adds more query tests to the Blitz-orm project. The existing tests in the query.test.ts file were analyzed to identify the types of queries that were not covered. New tests were added for these queries to ensure comprehensive test coverage. The testSchema.ts file was used to define the schema and the data.tql file was used to provide the necessary data for the tests.

Summary of Changes

Added new tests for queries in the query.test.ts file to cover types of queries that were not previously tested.
Modified the data.tql file to include additional data that was needed for the new tests.

Please review and merge this PR to enhance the test coverage for the Blitz-orm project.

Fixes #26.

🎉 Latest improvements to Sweep:

Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

sweep-ai · 2023-11-01T19:01:34Z

Sandbox Executions

Check tests/unit/queries/query.test.ts ✗

Sandbox logs for

trunk init 1/3 ✓

⡿ Downloading Trunk 1.17.1...
⡿ Downloading Trunk 1.17.1...
⢿ Downloading Trunk 1.17.1...
⣻ Downloading Trunk 1.17.1...
⣽ Downloading Trunk 1.17.1...
⣾ Downloading Trunk 1.17.1...
⣷ Downloading Trunk 1.17.1...
✔ Downloading Trunk 1.17.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done


✔ 10 linters were enabled (.trunk/trunk.yaml)
  checkov 3.0.15 (3 json, 2 yaml files)
  eslint 8.52.0 (2 javascript, 51 typescript files)
  git-diff-check (70 files)
  markdownlint 0.37.0 (2 markdown files) (created .markdownlint.yaml)
  prettier 3.0.3 (2 javascript, 3 json, 2 markdown, 1 prettier_supported_configs, 51 typescript, 2 yaml files)
  shellcheck 0.9.0 (1 shell file) (created .shellcheckrc)
  shfmt 3.6.0 (1 shell file)
  trivy 0.46.1 (2 yaml files)
  trufflehog 3.62.1 (70 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt tests/unit/queries/query.test.ts || exit 0 2/3 ✓

 ✔ Formatted tests/unit/queries/query.test.ts
Re-checking autofixed files...


Checked 1 file
✔ No issues

trunk check --fix --print-failures tests/unit/queries/query.test.ts 3/3 ❌ (`1`)

  FAILURES  
 eslint  tests/unit/queries/query.test.ts  .trunk/out/fMjpQ.yaml
 eslint  tests/unit/queries/query.test.ts  .trunk/out/pCrmN.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent      
 thereof                                                                                                                
 Some tools failed to run. You can open the details yaml files for more information.                                    
Checked 1 file
✖ No issues, 2 failures
# .trunk/out/fMjpQ.yaml
trunk_cli_version: 1.17.1
title: eslint exited with exit_code=2
report:
  - eslint exited with exit_code=2
  - suggestion: Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent thereof
  - linter:
      command: |
        /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/SJv9E3/6jNXiP8FYn5f --format json tests/unit/queries/query.test.ts
      stdin_path: (none)
      run_from: /tmp/trunk-0/mZYuu6/srRoG7
      timeout: 10m
      rerun: (cd /tmp/trunk-0/mZYuu6/srRoG7; env -i PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin NODE_PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules HOME=/root /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/SJv9E3/6jNXiP8FYn5f --format json tests/unit/queries/query.test.ts)
      affects_cache:
        - .eslintignore
        - package.json
        - tsconfig.json
      direct_configs:
        - .eslintrc
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        Oops! Something went wrong! :(
        ESLint: 8.52.0
        ESLint couldn't find the config "@blitznocode/eslint-config" to extend from. Please check that the name of the config is correct.
        The config "@blitznocode/eslint-config" was referenced from the config file in "/tmp/trunk-0/mZYuu6/srRoG7/.eslintrc".
        If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
    parser: |
      (none)
# .trunk/out/pCrmN.yaml
trunk_cli_version: 1.17.1
title: eslint exited with exit_code=2
report:
  - eslint exited with exit_code=2
  - suggestion: Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent thereof
  - linter:
      command: |
        /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/cg0vKx/qbquk1xNlQZA --format json tests/unit/queries/query.test.ts
      stdin_path: (none)
      run_from: /tmp/trunk-0/CuArlP/HNCUME
      timeout: 10m
      rerun: (cd /tmp/trunk-0/CuArlP/HNCUME; env -i PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin NODE_PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules HOME=/root /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/cg0vKx/qbquk1xNlQZA --format json tests/unit/queries/query.test.ts)
      affects_cache:
        - .eslintignore
        - package.json
        - tsconfig.json
      direct_configs:
        - .eslintrc
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        Oops! Something went wrong! :(
        ESLint: 8.52.0
        ESLint couldn't find the config "@blitznocode/eslint-config" to extend from. Please check that the name of the config is correct.
        The config "@blitznocode/eslint-config" was referenced from the config file in "/tmp/trunk-0/CuArlP/HNCUME/.eslintrc".
        If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
    parser: |
      (none)

Check package.json ✗

Run package.json through the sandbox.

Check .eslintrc ✗

Run .eslintrc through the sandbox.

Check tests/unit/queries/query.test.ts ✗

Sandbox logs for

trunk init 1/3 ✓

⡿ Downloading Trunk 1.17.1...
⡿ Downloading Trunk 1.17.1...
⢿ Downloading Trunk 1.17.1...
⣻ Downloading Trunk 1.17.1...
⣽ Downloading Trunk 1.17.1...
⣾ Downloading Trunk 1.17.1...
⣷ Downloading Trunk 1.17.1...
✔ Downloading Trunk 1.17.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done


✔ 10 linters were enabled (.trunk/trunk.yaml)
  checkov 3.0.15 (3 json, 2 yaml files)
  eslint 8.52.0 (2 javascript, 51 typescript files)
  git-diff-check (70 files)
  markdownlint 0.37.0 (2 markdown files) (created .markdownlint.yaml)
  prettier 3.0.3 (2 javascript, 3 json, 2 markdown, 1 prettier_supported_configs, 51 typescript, 2 yaml files)
  shellcheck 0.9.0 (1 shell file) (created .shellcheckrc)
  shfmt 3.6.0 (1 shell file)
  trivy 0.46.1 (2 yaml files)
  trufflehog 3.62.1 (70 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt tests/unit/queries/query.test.ts || exit 0 2/3 ✓

 ✔ Formatted tests/unit/queries/query.test.ts
Re-checking autofixed files...


Checked 1 file
✔ No issues

trunk check --fix --print-failures tests/unit/queries/query.test.ts 3/3 ❌ (`1`)

  FAILURES  
 eslint  tests/unit/queries/query.test.ts  .trunk/out/fMjpQ.yaml
 eslint  tests/unit/queries/query.test.ts  .trunk/out/pCrmN.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent      
 thereof                                                                                                                
 Some tools failed to run. You can open the details yaml files for more information.                                    
Checked 1 file
✖ No issues, 2 failures
# .trunk/out/fMjpQ.yaml
trunk_cli_version: 1.17.1
title: eslint exited with exit_code=2
report:
  - eslint exited with exit_code=2
  - suggestion: Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent thereof
  - linter:
      command: |
        /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/SJv9E3/6jNXiP8FYn5f --format json tests/unit/queries/query.test.ts
      stdin_path: (none)
      run_from: /tmp/trunk-0/mZYuu6/srRoG7
      timeout: 10m
      rerun: (cd /tmp/trunk-0/mZYuu6/srRoG7; env -i PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin NODE_PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules HOME=/root /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/SJv9E3/6jNXiP8FYn5f --format json tests/unit/queries/query.test.ts)
      affects_cache:
        - .eslintignore
        - package.json
        - tsconfig.json
      direct_configs:
        - .eslintrc
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        Oops! Something went wrong! :(
        ESLint: 8.52.0
        ESLint couldn't find the config "@blitznocode/eslint-config" to extend from. Please check that the name of the config is correct.
        The config "@blitznocode/eslint-config" was referenced from the config file in "/tmp/trunk-0/mZYuu6/srRoG7/.eslintrc".
        If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
    parser: |
      (none)
# .trunk/out/pCrmN.yaml
trunk_cli_version: 1.17.1
title: eslint exited with exit_code=2
report:
  - eslint exited with exit_code=2
  - suggestion: Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent thereof
  - linter:
      command: |
        /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/cg0vKx/qbquk1xNlQZA --format json tests/unit/queries/query.test.ts
      stdin_path: (none)
      run_from: /tmp/trunk-0/CuArlP/HNCUME
      timeout: 10m
      rerun: (cd /tmp/trunk-0/CuArlP/HNCUME; env -i PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin NODE_PATH=/root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules HOME=/root /root/.cache/trunk/tools/eslint/8.52.0-a618ad632f0aeb358b6d43b1e01c686f/node_modules/.bin/eslint --output-file /tmp/trunk-0/cg0vKx/qbquk1xNlQZA --format json tests/unit/queries/query.test.ts)
      affects_cache:
        - .eslintignore
        - package.json
        - tsconfig.json
      direct_configs:
        - .eslintrc
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        Oops! Something went wrong! :(
        ESLint: 8.52.0
        ESLint couldn't find the config "@blitznocode/eslint-config" to extend from. Please check that the name of the config is correct.
        The config "@blitznocode/eslint-config" was referenced from the config file in "/tmp/trunk-0/CuArlP/HNCUME/.eslintrc".
        If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
    parser: |
      (none)

Check tests/mocks/data.tql ✓

Sandbox logs for
trunk fmt tests/mocks/data.tql || exit 0 1/2 ✓
Found no applicable linters for the requested path
trunk check --fix --print-failures tests/mocks/data.tql 2/2 ✓
Checked 1 file
✔ No issues

sweep-ai · 2023-11-01T19:01:35Z

Apply Sweep Rules to your PR?

Apply: Leftover TODOs in the code should be handled.
Apply: All new business logic should have corresponding unit tests in the tests/ directory.
Apply: Any clearly inefficient or repeated code should be optimized or refactored.

sweep-ai bot added 2 commits November 1, 2023 18:54

feat: Updated tests/unit/queries/query.test.ts

73cd014

feat: Updated tests/mocks/data.tql

d29d060

sweep-ai bot added the sweep label Nov 1, 2023

sweep-ai bot mentioned this pull request Nov 1, 2023

Sweep: Add more query tests #26

Open

7 tasks

sweep-ai bot added 24 commits November 2, 2023 00:17

Merge main into sweep/add-query-tests

4351d2b

Merge main into sweep/add-query-tests

7b04551

Merge main into sweep/add-query-tests

ead09fb

Merge main into sweep/add-query-tests

f301c01

Merge main into sweep/add-query-tests

5de7b7a

Merge main into sweep/add-query-tests

3f94fa5

Merge main into sweep/add-query-tests

2998ae8

Merge main into sweep/add-query-tests

2af7b9d

Merge main into sweep/add-query-tests

8c222cf

Merge main into sweep/add-query-tests

6bba21a

Merge main into sweep/add-query-tests

06fefc8

Merge main into sweep/add-query-tests

c276803

Merge main into sweep/add-query-tests

dfb8839

Merge main into sweep/add-query-tests

21739b6

Merge main into sweep/add-query-tests

48f61c6

Merge main into sweep/add-query-tests

9991a8c

Merge main into sweep/add-query-tests

d2f875a

Merge main into sweep/add-query-tests

e911d6b

Merge main into sweep/add-query-tests

592ff26

Merge main into sweep/add-query-tests

f30064a

Merge main into sweep/add-query-tests

7335b83

Merge main into sweep/add-query-tests

d5c6a7e

Merge main into sweep/add-query-tests

4111fb5

Merge main into sweep/add-query-tests

7f4bc30

sweep-ai bot added 29 commits February 8, 2024 02:03

Merge main into sweep/add-query-tests

8758b81

Merge main into sweep/add-query-tests

163ee04

Merge main into sweep/add-query-tests

c527df8

Merge main into sweep/add-query-tests

8817cf9

Merge main into sweep/add-query-tests

b38e9b4

Merge main into sweep/add-query-tests

bcd181c

Merge main into sweep/add-query-tests

307eff3

Merge main into sweep/add-query-tests

e62d216

Merge main into sweep/add-query-tests

947b601

Merge main into sweep/add-query-tests

aa5c345

Merge main into sweep/add-query-tests

d656616

Merge main into sweep/add-query-tests

28c3813

Merge main into sweep/add-query-tests

b88b777

Merge main into sweep/add-query-tests

a9bc921

Merge main into sweep/add-query-tests

7d1302f

Merge main into sweep/add-query-tests

3944629

Merge main into sweep/add-query-tests

af7807a

Merge main into sweep/add-query-tests

ef3efe0

Merge main into sweep/add-query-tests

d06a732

Merge main into sweep/add-query-tests

3841389

Merge main into sweep/add-query-tests

2324916

Merge main into sweep/add-query-tests

4eed529

Merge main into sweep/add-query-tests

c86b734

Merge main into sweep/add-query-tests

5ba6607

Merge main into sweep/add-query-tests

d689995

Merge main into sweep/add-query-tests

6047726

Merge main into sweep/add-query-tests

65358fc

Merge main into sweep/add-query-tests

4d7666f

Merge main into sweep/add-query-tests

680fc69

lveillard closed this Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more query tests #27

Add more query tests #27

sweep-ai bot commented Nov 1, 2023 •

edited

Loading

sweep-ai bot commented Nov 1, 2023

sweep-ai bot commented Nov 1, 2023

Add more query tests #27

Add more query tests #27

Conversation

sweep-ai bot commented Nov 1, 2023 • edited Loading

PR Feedback: 👎

Description

Summary of Changes

🎉 Latest improvements to Sweep:

💡 To get Sweep to edit this pull request, you can:

sweep-ai bot commented Nov 1, 2023

Sandbox Executions

sweep-ai bot commented Nov 1, 2023

Apply Sweep Rules to your PR?

sweep-ai bot commented Nov 1, 2023 •

edited

Loading