Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a lot of commented code #4

Open
Blank1611 opened this issue Oct 15, 2020 · 0 comments
Open

There is a lot of commented code #4

Blank1611 opened this issue Oct 15, 2020 · 0 comments
Assignees
@Blank1611
Labels
invalid This doesn't seem right or can be optimized
Milestone
Redesign

Comments

@Blank1611
Copy link
Owner

Blank1611 commented Oct 15, 2020 •
edited
Loading

Remove unnecessary comments.
Restructure commented code as an optional functionality to utility

jsonmergeutils/merge_files.py

Line 90 in 75a432b

#self.redundant_obj()

Also include the optional code mentioned in README.md

jsonmergeutils/jsonmerge_utils.py

Line 50 in 75a432b

merge = Merge(path_creator(data_dir, input_prefix),

@Blank1611 Blank1611 added this to the Redesign milestone Oct 15, 2020
@Blank1611 Blank1611 added the invalid This doesn't seem right or can be optimized label Oct 15, 2020
@Blank1611 Blank1611 self-assigned this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blank1611 Blank1611

Labels
invalid This doesn't seem right or can be optimized
Projects
None yet
Milestone
Redesign
Development

No branches or pull requests
1 participant
@Blank1611