From dbee7f3b9f6ca5fe8b3540697860a939d8935ee5 Mon Sep 17 00:00:00 2001 From: fanquake Date: Wed, 6 Apr 2022 19:47:16 +0100 Subject: [PATCH] lint: remove qt SIGNAL/SLOT lint I think we are past the point where we need to lint for this, the CPU can probably be better utilized. --- src/qt/BGLgui.h | 2 +- test/lint/lint-qt.sh | 20 -------------------- 2 files changed, 1 insertion(+), 21 deletions(-) delete mode 100755 test/lint/lint-qt.sh diff --git a/src/qt/BGLgui.h b/src/qt/BGLgui.h index 60dd39899d..988affeab0 100644 --- a/src/qt/BGLgui.h +++ b/src/qt/BGLgui.h @@ -304,7 +304,7 @@ public Q_SLOTS: /** Show window if hidden, unminimize when minimized, rise when obscured or show if hidden and fToggleHidden is true */ void showNormalIfMinimized() { showNormalIfMinimized(false); } void showNormalIfMinimized(bool fToggleHidden); - /** Simply calls showNormalIfMinimized(true) for use in SLOT() macro */ + /** Simply calls showNormalIfMinimized(true) */ void toggleHidden(); /** called by a timer to check if ShutdownRequested() has been set **/ diff --git a/test/lint/lint-qt.sh b/test/lint/lint-qt.sh deleted file mode 100755 index 2e77682aa2..0000000000 --- a/test/lint/lint-qt.sh +++ /dev/null @@ -1,20 +0,0 @@ -#!/usr/bin/env bash -# -# Copyright (c) 2018 The Bitcoin Core developers -# Distributed under the MIT software license, see the accompanying -# file COPYING or http://www.opensource.org/licenses/mit-license.php. -# -# Check for SIGNAL/SLOT connect style, removed since Qt4 support drop. - -export LC_ALL=C - -EXIT_CODE=0 - -OUTPUT=$(git grep -E '(SIGNAL|, ?SLOT)\(' -- src/qt) -if [[ ${OUTPUT} != "" ]]; then - echo "Use Qt5 connect style in:" - echo "$OUTPUT" - EXIT_CODE=1 -fi - -exit ${EXIT_CODE}