Skip to content

Commit 5cdc53b

Browse files
committed
fix: disable vss verification
VSS verification does not currently work with current APIs. Will need to make changes before re-enabling. Ticket: BG-61040
1 parent 4a18c83 commit 5cdc53b

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

modules/bitgo/test/v2/unit/tss/eddsa.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,8 @@ describe('test tss helper functions', function () {
398398

399399
describe('offerUserToBitgoRShare:', async function() {
400400
it('should succeed to send Signature Share', async function() {
401-
const signatureShare = { from: 'user', to: 'bitgo', share: validUserSignShare.rShares[3].v + validUserSignShare.rShares[3].r + validUserSignShare.rShares[3].R } as SignatureShareRecord;
401+
// TODO(BG-61037): add back v when VSS signing is fixed
402+
const signatureShare = { from: 'user', to: 'bitgo', share: /* validUserSignShare.rShares[3].v + */ validUserSignShare.rShares[3].r + validUserSignShare.rShares[3].R } as SignatureShareRecord;
402403
const nock = await nockSendSignatureShare({ walletId: wallet.id(), txRequestId: txRequest.txRequestId, signatureShare, signerShare: 'signerShare' });
403404
await offerUserToBitgoRShare(bitgo, wallet.id(), txRequest.txRequestId, validUserSignShare, 'signerShare').should.be.fulfilled();
404405
nock.isDone().should.equal(true);

modules/sdk-core/src/account-lib/mpc/tss/eddsa/eddsa.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ export default class Eddsa {
135135
uShare.i
136136
);
137137
} catch (err) {
138-
throw new Error(`Could not verify share from participant ${share.j}. Verification error: ${err}`);
138+
// TODO(BG-61036): Fix Verification
139+
// throw new Error(`Could not verify share from participant ${share.j}. Verification error: ${err}`);
139140
}
140141
}
141142
}

modules/sdk-core/src/bitgo/tss/eddsa/eddsa.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,8 @@ export async function offerUserToBitgoRShare(
197197
const signatureShare: SignatureShareRecord = {
198198
from: SignatureShareType.USER,
199199
to: SignatureShareType.BITGO,
200-
share: rShare.v + rShare.r + rShare.R,
200+
// TODO(BG-61037): Fix signing with VSS
201+
share: /* rShare.v + */ rShare.r + rShare.R,
201202
};
202203

203204
// TODO (BG-57944): implement message signing for EDDSA

0 commit comments

Comments
 (0)