PHP8 release

[afk11]

Linking relevant issues and PR's here and any notes

• Composer 2 support
• Bump murmurhash3
• Bump mdanter/ecc Update mdanter/ecc to accept v1 and unblock php 8 upgrade #877
• Bump phpunit to test on new versions
• Fix phpunit deprecated features
• Make a release of secp256k1-php that works on php8.0, supporting the newer implementation from upstream (should be v0.3)x
• Finish bip-schnorr PR [WIP] Schnorr/Taproot/Tapscript #758 (needs updating to final spec)

[afk11]

#876 for phpunit fixup PR

[afk11]

Merge this #877

[abgit]

🙏

[satyr-software]

doesn't murmurhash3 still need ^2.1 for PHP8? ^2.0 still forced PHP ^7 I think.

[abgit]

doesn't murmurhash3 still need ^2.1 for PHP8? ^2.0 still forced PHP ^7 I think.

yes. v2.1.0 is the minimum murmurhash3 version for php8 support.

[BafS]

^2.0 doesn't force PHP^7, 2.0 does, which is the issue with the current composer file. Would it be possible to update ? It's not a breaking change.

[jorijn]

Any update on this? Its been a while :)

[BafS]

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

[jorijn]

@BafS This is awesome! Thanks.

[Aerendir]

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

The composer.json doesn't seem to be update to PHP8.0. What am I missing?

[BafS]

The composer.json doesn't seem to be update to PHP8.0. What am I missing?

Here is the commit to make it PHP 8.0 compatible: ProtonMail@b6ec4d2#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

[Aerendir]

The composer.json doesn't seem to be update to PHP8.0. What am I missing?

Here is the commit to make it PHP 8.0 compatible: ProtonMail@b6ec4d2#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

Thank you!

In the meantime I'm trying to simply skip the checks on the php requirement using

composer install --ignore-platform-req php

But I don't know if all works well now: I'm verifying...

[MatasR]

While using ur branch and trying to getHex() from signedTx i get this error (i think its related with PHP8 update):
Fatal error: Uncaught Error: Call to undefined method SplFixedArray::rewind() in C:\xampp\htdocs\crypto_api\vendor\protonlabs\bitcoin\src\Transaction\Mutator\AbstractCollectionMutator.php:43 Stack trace: #0 C:\xampp\htdocs\crypto_api\vendor\protonlabs\bitcoin\src\Transaction\Factory\Signer.php(179): BitWasp\Bitcoin\Transaction\Mutator\AbstractCollectionMutator->rewind() #1 C:\xampp\htdocs\crypto_api\config\Btc.php(47): BitWasp\Bitcoin\Transaction\Factory\Signer->get() #2 C:\xampp\htdocs\crypto_api\api\btc\transfer_from.php(39): Btc->signTransaction(Object(BitWasp\Bitcoin\Transaction\Transaction), Object(BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Key\PrivateKey), '68673') #3 {main} thrown in C:\xampp\htdocs\crypto_api\vendor\protonlabs\bitcoin\src\Transaction\Mutator\AbstractCollectionMutator.php on line 43

[BrianHenryIE]

This explains it (I haven’t tried to fix it):

SplFixedArray is now IteratorAggregate to support nested loops.

https://markbakeruk.net/2020/11/17/under-the-radar-a-backwards-compatible-break-for-splfixedarray-in-php-8/

[meglio]

Hey @afk11 have you abandoned it?

[PavelDonskikh]

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

Yes! it does actually help!