Skip to content

Add Minute_Of_Hour Function As An Alias Of Minute Function #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GabeFernandez310 merged 15 commits into from
Jan 5, 2023
Merged

Add Minute_Of_Hour Function As An Alias Of Minute Function #196

GabeFernandez310 merged 15 commits into from
Jan 5, 2023

Conversation

@GabeFernandez310
Copy link

@GabeFernandez310 GabeFernandez310 commented Dec 20, 2022

Description

Adds support for the minute_of_hour function as an alias for the minute function which currently exists in opensearch

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GabeFernandez310
Added Parser Implementation And Tests
6f5db80 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Added Implementation
3cd8d43 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Added Docs
060e1af 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Fixed Checkstyle In Tests
e8083dc 
Signed-off-by: GabeFernandez310 <[email protected]>
@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (integ-add-minute_of_hour-function@7edc72e). Click here to learn what that means.
The diff coverage is n/a.

@@                         Coverage Diff                          @@
##             integ-add-minute_of_hour-function     #196   +/-   ##
====================================================================
  Coverage                                     ?   95.82%           
  Complexity                                   ?     3542           
====================================================================
  Files                                        ?      356           
  Lines                                        ?     9400           
  Branches                                     ?      674           
====================================================================
  Hits                                         ?     9008           
  Misses                                       ?      334           
  Partials                                     ?       58
Flag Coverage Δ
query-workbench 62.76% <0.00%> (?)
sql-engine 98.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GabeFernandez310
Fixed Failing Unit Test
14d1b6d 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Fixed A Test Name
677efbc 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Fixed IT Test
890011d 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team December 21, 2022 15:49
Yury-Fridlyand
Yury-Fridlyand reviewed Dec 21, 2022
View reviewed changes
@GabeFernandez310 GabeFernandez310 requested a review from a team December 22, 2022 23:08
@GabeFernandez310
Added Support For Date Type
aa19904 
Signed-off-by: GabeFernandez310 <[email protected]>
acarbonetto
acarbonetto approved these changes Dec 29, 2022
View reviewed changes
docs/user/dql/functions.rst
>>>>>>>>>>>

Usage: minute(time) returns the minute for time, in the range 0 to 59.
The `minute_of_hour` function is provided as an alias.
Copy link

@acarbonetto acarbonetto Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscore for a link

Copy link

@Yury-Fridlyand Yury-Fridlyand Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no section for minute_of_hour to link to

Yury-Fridlyand
Yury-Fridlyand reviewed Jan 3, 2023
View reviewed changes
@GabeFernandez310
Fixed Tests
b3ee7b4 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Fixed documentation
6deaafb 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Refactored Tests
17510af 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Fixed Spacing
44ec60e 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310
Removed white space
ed4f30b 
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 merged commit b89fccc into integ-add-minute_of_hour-function Jan 5, 2023
GabeFernandez310 added a commit that referenced this pull request Jan 5, 2023
@GabeFernandez310
Add Minute_Of_Hour Function As An Alias Of Minute Function (#196)
89dba98 
Added Testing And Implementation For Minute_Of_Hour Function

Signed-off-by: GabeFernandez310 <[email protected]>
GabeFernandez310 added a commit that referenced this pull request Jan 6, 2023
@GabeFernandez310
Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (op…
61e2374 
…ensearch-project#1230)

Added Testing And Implementation For Minute_Of_Hour Function

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
GabeFernandez310 added a commit that referenced this pull request Jan 9, 2023
@GabeFernandez310
Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (op…
399b454 
…ensearch-project#1230)

Added Testing And Implementation For Minute_Of_Hour Function

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 61e2374)
matthewryanwells pushed a commit that referenced this pull request Feb 1, 2023
@GabeFernandez310
[Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Func…
9b2ad5a 
…tion (opensearch-project#1253)

* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (opensearch-project#1230)

Added Testing And Implementation For Minute_Of_Hour Function

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 61e2374)

* Added Missing Imports

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

+2 more reviewers

@GumpacG GumpacG GumpacG approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GabeFernandez310 @GumpacG @Yury-Fridlyand @acarbonetto