Skip to content

Commit 633d495

Browse files
committed
[Spotless] Applying Google Code Format for core/src/main files #4 (opensearch-project#1933)
* GJF part 4 Signed-off-by: Mitchell Gale <[email protected]> * add build.gradle comment to mention why we are ignoring checkstyle failures for core. Signed-off-by: Mitchell Gale <[email protected]> * Fix include spotless build gradle. Signed-off-by: Mitchell Gale <[email protected]> * revert astDSL.JAVA Signed-off-by: Mitchell Gale <[email protected]> * revert ast changes as was covered in spotless #1 PR for GJF. Signed-off-by: Mitchell Gale <[email protected]> * Reverting commits in ast folder attempt #2 Signed-off-by: Mitchell Gale <[email protected]> * revert change to RaretopN.java Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments. Signed-off-by: Mitchell Gale <[email protected]> * Replacing removed include in spotless. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
1 parent 3bcd3a1 commit 633d495

17 files changed

+1221
-1320
lines changed

build.gradle

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,11 @@ repositories {
8484
spotless {
8585
java {
8686
target fileTree('.') {
87-
include 'core/src/main/java/org/opensearch/sql/planner/**/*.java',
87+
include 'core/src/main/java/org/opensearch/sql/DataSourceSchemaName.java',
88+
'core/src/test/java/org/opensearch/sql/data/**/*.java',
89+
'core/src/test/java/org/opensearch/sql/config/**/*.java',
90+
'core/src/test/java/org/opensearch/sql/analysis/**/*.java',
91+
'core/src/main/java/org/opensearch/sql/planner/**/*.java',
8892
'core/src/main/java/org/opensearch/sql/storage/**/*.java',
8993
'core/src/main/java/org/opensearch/sql/utils/**/*.java',
9094
'core/src/main/java/org/opensearch/sql/monitor/**/*.java',

core/build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ repositories {
3434
mavenCentral()
3535
}
3636

37-
checkstyleMain.ignoreFailures = true
37+
// Being ignored as a temporary measure before being removed in favour of
38+
// spotless https://github.com/opensearch-project/sql/issues/1101
3839
checkstyleTest.ignoreFailures = true
40+
checkstyleMain.ignoreFailures = true
3941

4042
pitest {
4143
targetClasses = ['org.opensearch.sql.*']

core/src/main/java/org/opensearch/sql/DataSourceSchemaName.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,4 @@ public class DataSourceSchemaName {
1717
private final String dataSourceName;
1818

1919
private final String schemaName;
20-
2120
}

core/src/test/java/org/opensearch/sql/analysis/AnalysisContextTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
76
package org.opensearch.sql.analysis;
87

98
import static org.junit.jupiter.api.Assertions.assertEquals;

0 commit comments

Comments
 (0)