Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover Color Stops Working for Green Stars #108

Open
seanieboi opened this issue Feb 22, 2019 · 1 comment
Open

Hover Color Stops Working for Green Stars #108

seanieboi opened this issue Feb 22, 2019 · 1 comment

Comments

@seanieboi
Copy link

I'm submitting a...


[X] Bug report  
[ ] Feature request

Current behavior

When more than 6 stars are selected the fill stops working for the green stars

Expected behavior

Hover fill keeps working

Minimal reproduction of the problem with instructions

Add the following config:

<star-rating
[starType]="'svg'"
size="large"
[hoverEnabled]="true"
[numOfStars]="8"
>

Or go to https://biophoton.github.io/angular-star-rating/#/property-bindings and change amount of stars to 10

Environment


"angular-star-rating": "^4.0.0-beta.3"
"css-star-rating": "^1.2.4"
Angular version: 5


Browser:

- [X] Chrome (desktop) version 72
@corentinthibaud
Copy link

To make it work, before importing scss from css-star-rating, make sure to define the variable $maxNumOfStars to the number of stars you have + 1.
This is due to the fact that you can not pass variable from TypeScript to SCSS files directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants