Issue with Camlzip 1.12

[xavierleroy]

For reasons explained in ocaml/opam-repository#26207 (comment) , Camlzip version 1.12 removes the extra field from type Zip.entry. This breaks lib/bap_byteweight/bap_byteweight_signatures.ml:

bap/lib/bap_byteweight/bap_byteweight_signatures.ml

Lines 103 to 114 in 95e8173

	let update_or_fail ?compiler target data payload path =
	let entries =
	read_entries path |>
	List.filter ~f:(fun (entry,_) ->
	not (matching_entry ?compiler target data entry)) in
	with_output path @@ fun zip ->
	let path = make_entry ?compiler target data in
	let data = Bytes.unsafe_to_string (data.save payload) in
	Zip.add_entry data zip path;
	List.iter entries ~f:(fun ({Zip.filename; extra; comment; mtime},data) ->
	Zip.add_entry data zip filename
	~extra ~comment ~mtime)

I suggest not trying to copy the extra data at all.

[ivg]

Thanks @xavierleroy and @bmourad01, closing the issue as fixed in #1609