Setting Starknet DEPOSIT_SELECTOR in contracts #65
threepwave
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I've been looking through the Realms Bridge contract (URL below) and trying to think about future proofing. It looks like we have setters in place for the L2 Bridge address, the L1 Realms contract address, and the Starknet core address. DEPOSIT_SELECTOR, however, is hardcoded as a constant.
Is it possible for this value to change? Might be worth creating a setter for this just in case.
https://github.com/BibliothecaForAdventurers/realms-contracts/blob/01bf276bcaa994b9e7c9940d47cee67c7b136fd2/contracts/l1/bridge/RealmsBridgeLockbox.sol#L24
@lordabrax
Beta Was this translation helpful? Give feedback.
All reactions