Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import statements #80

Open
verbman opened this issue Sep 7, 2018 · 1 comment
Open

Import statements #80

verbman opened this issue Sep 7, 2018 · 1 comment
Labels

Comments

@verbman
Copy link
Member

verbman commented Sep 7, 2018

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

I used the default import statement:
from openfisca_core.model_api import *

Here is what I expected to happen:

It worked but I felt like it's not best practice yet it's current practice and think we should have a conversation about it.

Here is what I propose we do:

from openfisca_core.model_api import MONTH, YEAR

Context

I identify more as a:

  • Developer (I create tools that use the existing OpenFisca code).
@verbman verbman changed the title import statements Import statements Sep 7, 2018
@Br3nda
Copy link
Member

Br3nda commented Sep 18, 2018

agreed. we might be able to convince the flake8 linter to fail these

@Br3nda Br3nda added the lint label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants