Don't crash when original_exception is nil #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that exception.orignal_exception is an exception if the exception respond_to? :orignal_exception [Certain exception types](http://api.rubyonrails.org/classes/ActiveRecord/StatementInvalid.html) respond_to? original_exception, but [the value may not be set]( https://github.com/rails/rails/blob/df2226ea16922fd4e2ea72b8ee372a4cb5621114/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L499) and it would cause an [undefined method message for nil class exception in better_errors](https://github.com/charliesome/better_errors/blob/3be2c834e8a644cfd5436f0b107c70d713f46de6/lib/better_errors/middleware.rb#L118).
|
Thanks! |
haileys
pushed a commit
that referenced
this pull request
Nov 30, 2013
Don't crash when original_exception is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that exception.orignal_exception is an exception if the exception respond_to? :orignal_exception
Certain exception types respond_to? original_exception, but the value may not be set
and it would cause an undefined method message for nil class exception in better_errors.