Stack frame should be able to handle BasicObject-like bindings

[kostia]

Fixes #178

[haileys]

I would prefer it if this was fixed by using ::Kernel.method rather than rescuing from a NameError

On 28/06/2013, at 2:33, Kostiantyn Kahanskyi [email protected] wrote:

Fixes #178

You can merge this Pull Request by running

git pull https://github.com/kostia/better_errors basic_object_fix
Or view, comment on, or merge it at:

#179

Commit Summary

Stack frame should be able to handle BasicObject-like bindings
File Changes

M lib/better_errors/stack_frame.rb (10)
M spec/better_errors/stack_frame_spec.rb (6)
Patch Links:

https://github.com/charliesome/better_errors/pull/179.patch
https://github.com/charliesome/better_errors/pull/179.diff

[kostia]

Ok.
What would you expect as @class_name? Because BasicObject can't do such kind of reflexion and in this case delegating to Kernel or whatever would not help.

[haileys]

@kostia This works in Ruby 2.0:

Kernel.instance_method(:class).bind(BasicObject.new).call

[kostia]

@charliesome I know, but it would not work in 1.9.3 and below.

[haileys]

I'm ok with making 1.9 a second class platform.

I don't want to drop support for 1.9 straight away, but it's ok if there are enhancements only available on 2.0.

On 29/06/2013, at 9:01, Kostiantyn Kahanskyi [email protected] wrote:

@charliesome I know, but it would not work in 1.9.3 and below.

—
Reply to this email directly or view it on GitHub.

[kostia]

@charliesome I've changed it so, that the decoration fully works in Ruby >= 2.0.0 and doesn't blow up in below versions.