Adjust the backtrace to look more like rails. Adds the enhancement requested in #29. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the gem before it's file path. Adds the enhancement requested in #29.
|
I like it, I've been wanting to have this done myself. Thanks for the contribution. |
rstacruz
added a commit
that referenced
this pull request
Apr 17, 2013
Adjust the backtrace to look more like rails. Adds the enhancement requested in #29.
| @@ -50,7 +50,7 @@ def gem? | |||
| def gem_path | |||
| Gem.path.each do |path| | |||
| if filename.index(path) == 0 | |||
| return filename.gsub("#{path}/gems/", "(gem) ") | |||
| return filename.gsub(%r{#{path}/gems/([^/]+)-([\w.]+)/}, '\1 (\2) ') | |||
There was a problem hiding this comment.
What happens if path contains special regex characters?
There was a problem hiding this comment.
Uh oh, you're right, the dot is especially vulnerable.
There was a problem hiding this comment.
Let me fix that in a commit, hold on
There was a problem hiding this comment.
Okay cool, go ahead then. :) Sorry I glanced over that hole.
haileys
pushed a commit
that referenced
this pull request
Apr 17, 2013
|
Oh wow, didn't think of that. Sorry about that guys. |
mjc
added a commit
to CentroNet-Marketing/better_errors
that referenced
this pull request
Jul 18, 2013
This reverts commit e08eccf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in issue #29, this enhances the backtrace to look more like Rails. It outputs the gem name, it's version (in parentheses) followed by the file path.