Make better_errors work when env["REMOTE_ADDR"] is empty #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
I'm experiencing the same issue with the Puma webserver. Fix of @Hackeron works for me, merge into master would be appreciated! |
|
I am running into this issue. It seems less to do with the useage of puma as a webserver, but nginx as your reverse proxy. That said, I would like to see a solution merged into master. |
|
Same issue here |
haileys
pushed a commit
that referenced
this pull request
Aug 2, 2013
Make better_errors work when env["REMOTE_ADDR"] is empty
haileys
pushed a commit
that referenced
this pull request
Aug 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puma, when used behind a reverse proxy sets an empty env["REMOTE_ADDR"] and this make better_errors throw a nasty exception on every page and basically stops your rails app from working. Details in issue #125. This 1 line fixes it.