StackFrame#from_exception should not fail with native java exceptions

[kowal]

Currently on JRuby versions 1.6.8, 1.7.0, 1.7.1, 1.7.2, You can run into error:

undefined method `__better_errors_bindings_stack' for java.lang.Exception: oops:Java::JavaLang::Exception
     # ./lib/better_errors/stack_frame.rb:5:in `from_exception'

This is simple fix to not fail with undefined method. I've added missing method to all native java exceptions - for now it returns empty array, just to fallback to #backtrace in StackFrame#from_exception.

I also updated .gemspec work with jruby 1.6.8.

I'm not sure how to write specs for that kind of 'platform specific' features. Maybe it would be good idea to put them into separate file? Any suggestions are welcome.

[haileys]

I'm not sure what I think of this to be honest. I would like to support all kinds of exceptions in all Ruby implementations, but it annoys me that java.lang.Exception objects don't behave like regular Exception objects in JRuby.

[kowal]

I think I made it more complicated than is actually is.

What I really wanted to fix in this PR is failing on missing __better_errors_bindings_stack. In order to do this, we can simply examine the exception with respond_to?. JRuby exceptions responds to backtrace, so 2nd condition in StackFrame#from_exception will work fine.

I'll update code tomorrow.

[kowal]

@charliesome please take a look at this now.

rvm 1.9.3,1.6.8,1.7.0,1.7.1,1.7.2 --verbose do rspec spec/ - all green.

You might have to install json gem for JRuby 1.6.8 - not sure if this should be included in .gemspec (I removed this change introduced in 1st PR version) as it's not required on latter versions anymore.

[haileys]

You might have to install json gem for JRuby 1.6.8

json is in the standard library as of Ruby 1.9. If you're running JRuby in 1.9 mode, shouldn't json be present without having to use a gem?

[kowal]

I guess it is a bug in JRuby, however I can't find actual bug report for this.

When testing on 1.6.x I was getting LoadError for json (without 'json' gem installed)

rvm 1.7.0 do jruby -r rubygems -e "puts require('json')" # => true

rvm 1.6.8 do jruby --1.9 -r rubygems -e "puts require('json')"
LoadError: no such file to load -- json
  require at org/jruby/RubyKernel.java:1071
  ..

[kowal]

@charliesome - any updates for this issues?

[gioele]

This problem still occurs with better_errors 0.9.0 and JRuby 1.7.4

[kowal]

@charliesome - any updates on this?