diff --git a/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroupDetails.ts b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroupDetails.ts new file mode 100644 index 00000000000..c0379b25321 --- /dev/null +++ b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroupDetails.ts @@ -0,0 +1,63 @@ +import { useQuery, useQueryClient } from "@tanstack/react-query"; +import { + getProxyBaseUrl, + getGlobalLitellmHeaderName, + deriveErrorMessage, + handleError, +} from "@/components/networking"; +import { all_admin_roles } from "@/utils/roles"; +import useAuthorized from "@/app/(dashboard)/hooks/useAuthorized"; +import { AccessGroupResponse, accessGroupKeys } from "./useAccessGroups"; + +// ── Fetch function ─────────────────────────────────────────────────────────── + +const fetchAccessGroupDetails = async ( + accessToken: string, + accessGroupId: string, +): Promise => { + const baseUrl = getProxyBaseUrl(); + const url = `${baseUrl}/v1/access_group/${encodeURIComponent(accessGroupId)}`; + + const response = await fetch(url, { + method: "GET", + headers: { + [getGlobalLitellmHeaderName()]: `Bearer ${accessToken}`, + "Content-Type": "application/json", + }, + }); + + if (!response.ok) { + const errorData = await response.json(); + const errorMessage = deriveErrorMessage(errorData); + handleError(errorMessage); + throw new Error(errorMessage); + } + + return response.json(); +}; + +// ── Hook ───────────────────────────────────────────────────────────────────── + +export const useAccessGroupDetails = (accessGroupId?: string) => { + const { accessToken, userRole } = useAuthorized(); + const queryClient = useQueryClient(); + + return useQuery({ + queryKey: accessGroupKeys.detail(accessGroupId!), + queryFn: async () => fetchAccessGroupDetails(accessToken!, accessGroupId!), + enabled: + Boolean(accessToken && accessGroupId) && + all_admin_roles.includes(userRole || ""), + + // Seed from the list cache when available + initialData: () => { + if (!accessGroupId) return undefined; + + const groups = queryClient.getQueryData( + accessGroupKeys.list({}), + ); + + return groups?.find((g) => g.access_group_id === accessGroupId); + }, + }); +}; diff --git a/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroups.test.ts b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroups.test.ts new file mode 100644 index 00000000000..587064353ac --- /dev/null +++ b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroups.test.ts @@ -0,0 +1,242 @@ +/* @vitest-environment jsdom */ +import React from "react"; +import { renderHook, waitFor } from "@testing-library/react"; +import { describe, it, expect, vi, beforeEach } from "vitest"; +import { QueryClient, QueryClientProvider } from "@tanstack/react-query"; +import { useAccessGroups, AccessGroupResponse } from "./useAccessGroups"; +import * as networking from "@/components/networking"; + +vi.mock("@/components/networking", () => ({ + getProxyBaseUrl: vi.fn(() => "http://proxy.example"), + getGlobalLitellmHeaderName: vi.fn(() => "Authorization"), + deriveErrorMessage: vi.fn((data: unknown) => (data as { detail?: string })?.detail ?? "Unknown error"), + handleError: vi.fn(), +})); + +vi.mock("@/app/(dashboard)/hooks/useAuthorized", () => ({ + default: vi.fn(() => ({ + accessToken: "test-token-123", + userRole: "Admin", + })), +})); + +const createQueryClient = () => + new QueryClient({ + defaultOptions: { + queries: { + retry: false, + gcTime: 0, + }, + }, + }); + +const wrapper = ({ children }: { children: React.ReactNode }) => { + const queryClient = createQueryClient(); + return React.createElement(QueryClientProvider, { client: queryClient }, children); +}; + +const mockAccessToken = "test-token-123"; +const mockAccessGroups: AccessGroupResponse[] = [ + { + access_group_id: "ag-1", + access_group_name: "Group One", + description: "First group", + access_model_ids: [], + access_mcp_server_ids: [], + access_agent_ids: [], + assigned_team_ids: [], + assigned_key_ids: [], + created_at: "2025-01-01T00:00:00Z", + created_by: "user-1", + updated_at: "2025-01-01T00:00:00Z", + updated_by: "user-1", + }, +]; + +const fetchMock = vi.fn(); + +describe("useAccessGroups", () => { + beforeEach(async () => { + vi.clearAllMocks(); + vi.mocked(networking.getProxyBaseUrl).mockReturnValue("http://proxy.example"); + vi.mocked(networking.getGlobalLitellmHeaderName).mockReturnValue("Authorization"); + + const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized"); + vi.mocked(useAuthorizedModule.default).mockReturnValue({ + accessToken: mockAccessToken, + userRole: "Admin", + } as any); + + global.fetch = fetchMock; + }); + + it("should return hook result without errors", () => { + fetchMock.mockResolvedValue({ + ok: true, + json: () => Promise.resolve([]), + } as Response); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + expect(result.current).toBeDefined(); + expect(result.current).toHaveProperty("data"); + expect(result.current).toHaveProperty("isSuccess"); + expect(result.current).toHaveProperty("isError"); + expect(result.current).toHaveProperty("status"); + }); + + it("should return access groups when access token and admin role are present", async () => { + fetchMock.mockResolvedValue({ + ok: true, + json: () => Promise.resolve(mockAccessGroups), + } as Response); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + await waitFor(() => { + expect(result.current.isSuccess).toBe(true); + }); + + expect(fetchMock).toHaveBeenCalledWith( + "http://proxy.example/v1/access_group", + expect.objectContaining({ + method: "GET", + headers: expect.objectContaining({ + Authorization: `Bearer ${mockAccessToken}`, + "Content-Type": "application/json", + }), + }), + ); + expect(result.current.data).toEqual(mockAccessGroups); + }); + + it("should not fetch when access token is null", async () => { + const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized"); + vi.mocked(useAuthorizedModule.default).mockReturnValue({ + accessToken: null, + userRole: "Admin", + } as any); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + expect(result.current.isFetching).toBe(false); + expect(result.current.isLoading).toBe(false); + expect(result.current.data).toBeUndefined(); + expect(fetchMock).not.toHaveBeenCalled(); + }); + + it("should not fetch when access token is empty string", async () => { + const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized"); + vi.mocked(useAuthorizedModule.default).mockReturnValue({ + accessToken: "", + userRole: "Admin", + } as any); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + expect(result.current.isFetching).toBe(false); + expect(result.current.isLoading).toBe(false); + expect(result.current.data).toBeUndefined(); + expect(fetchMock).not.toHaveBeenCalled(); + }); + + it("should not fetch when user role is not an admin role", async () => { + const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized"); + vi.mocked(useAuthorizedModule.default).mockReturnValue({ + accessToken: mockAccessToken, + userRole: "Viewer", + } as any); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + expect(result.current.isFetching).toBe(false); + expect(result.current.isLoading).toBe(false); + expect(result.current.data).toBeUndefined(); + expect(fetchMock).not.toHaveBeenCalled(); + }); + + it("should not fetch when user role is null", async () => { + const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized"); + vi.mocked(useAuthorizedModule.default).mockReturnValue({ + accessToken: mockAccessToken, + userRole: null, + } as any); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + expect(result.current.isFetching).toBe(false); + expect(result.current.isLoading).toBe(false); + expect(result.current.data).toBeUndefined(); + expect(fetchMock).not.toHaveBeenCalled(); + }); + + it("should fetch when user role is proxy_admin", async () => { + const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized"); + vi.mocked(useAuthorizedModule.default).mockReturnValue({ + accessToken: mockAccessToken, + userRole: "proxy_admin", + } as any); + + fetchMock.mockResolvedValue({ + ok: true, + json: () => Promise.resolve(mockAccessGroups), + } as Response); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + await waitFor(() => { + expect(result.current.isSuccess).toBe(true); + }); + + expect(fetchMock).toHaveBeenCalled(); + expect(result.current.data).toEqual(mockAccessGroups); + }); + + it("should expose error state when fetch fails", async () => { + fetchMock.mockResolvedValue({ + ok: false, + json: () => Promise.resolve({ detail: "Forbidden" }), + } as Response); + vi.mocked(networking.deriveErrorMessage).mockReturnValue("Forbidden"); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + await waitFor(() => { + expect(result.current.isError).toBe(true); + }); + + expect(result.current.error).toBeInstanceOf(Error); + expect((result.current.error as Error).message).toBe("Forbidden"); + expect(result.current.data).toBeUndefined(); + expect(networking.handleError).toHaveBeenCalledWith("Forbidden"); + }); + + it("should return empty array when API returns empty list", async () => { + fetchMock.mockResolvedValue({ + ok: true, + json: () => Promise.resolve([]), + } as Response); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + await waitFor(() => { + expect(result.current.isSuccess).toBe(true); + }); + + expect(result.current.data).toEqual([]); + }); + + it("should propagate network errors", async () => { + const networkError = new Error("Network failure"); + fetchMock.mockRejectedValue(networkError); + + const { result } = renderHook(() => useAccessGroups(), { wrapper }); + + await waitFor(() => { + expect(result.current.isError).toBe(true); + }); + + expect(result.current.error).toEqual(networkError); + expect(result.current.data).toBeUndefined(); + }); +}); diff --git a/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroups.ts b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroups.ts new file mode 100644 index 00000000000..e5d8829278d --- /dev/null +++ b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useAccessGroups.ts @@ -0,0 +1,70 @@ +import { useQuery } from "@tanstack/react-query"; +import { createQueryKeys } from "../common/queryKeysFactory"; +import { + getProxyBaseUrl, + getGlobalLitellmHeaderName, + deriveErrorMessage, + handleError, +} from "@/components/networking"; +import { all_admin_roles } from "@/utils/roles"; +import useAuthorized from "@/app/(dashboard)/hooks/useAuthorized"; + +// ── Types ──────────────────────────────────────────────────────────────────── + +export interface AccessGroupResponse { + access_group_id: string; + access_group_name: string; + description: string | null; + access_model_ids: string[]; + access_mcp_server_ids: string[]; + access_agent_ids: string[]; + assigned_team_ids: string[]; + assigned_key_ids: string[]; + created_at: string; + created_by: string | null; + updated_at: string; + updated_by: string | null; +} + +// ── Query keys (shared across access-group hooks) ──────────────────────────── + +export const accessGroupKeys = createQueryKeys("accessGroups"); + +// ── Fetch function ─────────────────────────────────────────────────────────── + +const fetchAccessGroups = async ( + accessToken: string, +): Promise => { + const baseUrl = getProxyBaseUrl(); + const url = `${baseUrl}/v1/access_group`; + + const response = await fetch(url, { + method: "GET", + headers: { + [getGlobalLitellmHeaderName()]: `Bearer ${accessToken}`, + "Content-Type": "application/json", + }, + }); + + if (!response.ok) { + const errorData = await response.json(); + const errorMessage = deriveErrorMessage(errorData); + handleError(errorMessage); + throw new Error(errorMessage); + } + + return response.json(); +}; + +// ── Hook ───────────────────────────────────────────────────────────────────── + +export const useAccessGroups = () => { + const { accessToken, userRole } = useAuthorized(); + + return useQuery({ + queryKey: accessGroupKeys.list({}), + queryFn: async () => fetchAccessGroups(accessToken!), + enabled: + Boolean(accessToken) && all_admin_roles.includes(userRole || ""), + }); +}; diff --git a/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useCreateAccessGroup.ts b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useCreateAccessGroup.ts new file mode 100644 index 00000000000..4d71be94455 --- /dev/null +++ b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useCreateAccessGroup.ts @@ -0,0 +1,68 @@ +import { useMutation, useQueryClient } from "@tanstack/react-query"; +import { + getProxyBaseUrl, + getGlobalLitellmHeaderName, + deriveErrorMessage, + handleError, +} from "@/components/networking"; +import useAuthorized from "@/app/(dashboard)/hooks/useAuthorized"; +import { AccessGroupResponse, accessGroupKeys } from "./useAccessGroups"; + +// ── Types ──────────────────────────────────────────────────────────────────── + +export interface AccessGroupCreateParams { + access_group_name: string; + description?: string | null; + access_model_ids?: string[]; + access_mcp_server_ids?: string[]; + access_agent_ids?: string[]; + assigned_team_ids?: string[]; + assigned_key_ids?: string[]; +} + +// ── Fetch function ─────────────────────────────────────────────────────────── + +const createAccessGroup = async ( + accessToken: string, + params: AccessGroupCreateParams, +): Promise => { + const baseUrl = getProxyBaseUrl(); + const url = `${baseUrl}/v1/access_group`; + + const response = await fetch(url, { + method: "POST", + headers: { + [getGlobalLitellmHeaderName()]: `Bearer ${accessToken}`, + "Content-Type": "application/json", + }, + body: JSON.stringify(params), + }); + + if (!response.ok) { + const errorData = await response.json(); + const errorMessage = deriveErrorMessage(errorData); + handleError(errorMessage); + throw new Error(errorMessage); + } + + return response.json(); +}; + +// ── Hook ───────────────────────────────────────────────────────────────────── + +export const useCreateAccessGroup = () => { + const { accessToken } = useAuthorized(); + const queryClient = useQueryClient(); + + return useMutation({ + mutationFn: async (params) => { + if (!accessToken) { + throw new Error("Access token is required"); + } + return createAccessGroup(accessToken, params); + }, + onSuccess: () => { + queryClient.invalidateQueries({ queryKey: accessGroupKeys.all }); + }, + }); +}; diff --git a/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useDeleteAccessGroup.ts b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useDeleteAccessGroup.ts new file mode 100644 index 00000000000..5df5960ce0a --- /dev/null +++ b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useDeleteAccessGroup.ts @@ -0,0 +1,55 @@ +import { useMutation, useQueryClient } from "@tanstack/react-query"; +import { + getProxyBaseUrl, + getGlobalLitellmHeaderName, + deriveErrorMessage, + handleError, +} from "@/components/networking"; +import useAuthorized from "@/app/(dashboard)/hooks/useAuthorized"; +import { accessGroupKeys } from "./useAccessGroups"; + +// ── Fetch function ─────────────────────────────────────────────────────────── + +const deleteAccessGroup = async ( + accessToken: string, + accessGroupId: string, +): Promise => { + const baseUrl = getProxyBaseUrl(); + const url = `${baseUrl}/v1/access_group/${encodeURIComponent(accessGroupId)}`; + + const response = await fetch(url, { + method: "DELETE", + headers: { + [getGlobalLitellmHeaderName()]: `Bearer ${accessToken}`, + "Content-Type": "application/json", + }, + }); + + if (!response.ok) { + const errorData = await response.json(); + const errorMessage = deriveErrorMessage(errorData); + handleError(errorMessage); + throw new Error(errorMessage); + } + + // 204 No Content — nothing to parse +}; + +// ── Hook ───────────────────────────────────────────────────────────────────── + +export const useDeleteAccessGroup = () => { + const { accessToken } = useAuthorized(); + const queryClient = useQueryClient(); + + return useMutation({ + mutationFn: async (accessGroupId) => { + if (!accessToken) { + throw new Error("Access token is required"); + } + return deleteAccessGroup(accessToken, accessGroupId); + }, + onSuccess: () => { + queryClient.invalidateQueries({ queryKey: accessGroupKeys.all }); + }, + }); +}; diff --git a/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useEditAccessGroup.ts b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useEditAccessGroup.ts new file mode 100644 index 00000000000..1646458c63d --- /dev/null +++ b/ui/litellm-dashboard/src/app/(dashboard)/hooks/accessGroups/useEditAccessGroup.ts @@ -0,0 +1,77 @@ +import { useMutation, useQueryClient } from "@tanstack/react-query"; +import { + getProxyBaseUrl, + getGlobalLitellmHeaderName, + deriveErrorMessage, + handleError, +} from "@/components/networking"; +import useAuthorized from "@/app/(dashboard)/hooks/useAuthorized"; +import { AccessGroupResponse, accessGroupKeys } from "./useAccessGroups"; + +// ── Types ──────────────────────────────────────────────────────────────────── + +export interface AccessGroupUpdateParams { + access_group_name?: string; + description?: string | null; + access_model_ids?: string[]; + access_mcp_server_ids?: string[]; + access_agent_ids?: string[]; + assigned_team_ids?: string[]; + assigned_key_ids?: string[]; +} + +export interface EditAccessGroupVariables { + accessGroupId: string; + params: AccessGroupUpdateParams; +} + +// ── Fetch function ─────────────────────────────────────────────────────────── + +const updateAccessGroup = async ( + accessToken: string, + accessGroupId: string, + params: AccessGroupUpdateParams, +): Promise => { + const baseUrl = getProxyBaseUrl(); + const url = `${baseUrl}/v1/access_group/${encodeURIComponent(accessGroupId)}`; + + const response = await fetch(url, { + method: "PUT", + headers: { + [getGlobalLitellmHeaderName()]: `Bearer ${accessToken}`, + "Content-Type": "application/json", + }, + body: JSON.stringify(params), + }); + + if (!response.ok) { + const errorData = await response.json(); + const errorMessage = deriveErrorMessage(errorData); + handleError(errorMessage); + throw new Error(errorMessage); + } + + return response.json(); +}; + +// ── Hook ───────────────────────────────────────────────────────────────────── + +export const useEditAccessGroup = () => { + const { accessToken } = useAuthorized(); + const queryClient = useQueryClient(); + + return useMutation({ + mutationFn: async ({ accessGroupId, params }) => { + if (!accessToken) { + throw new Error("Access token is required"); + } + return updateAccessGroup(accessToken, accessGroupId, params); + }, + onSuccess: (_data, { accessGroupId }) => { + queryClient.invalidateQueries({ queryKey: accessGroupKeys.all }); + queryClient.invalidateQueries({ + queryKey: accessGroupKeys.detail(accessGroupId), + }); + }, + }); +}; diff --git a/ui/litellm-dashboard/src/app/page.tsx b/ui/litellm-dashboard/src/app/page.tsx index 28b8d81cc56..ae3bd76e3cf 100644 --- a/ui/litellm-dashboard/src/app/page.tsx +++ b/ui/litellm-dashboard/src/app/page.tsx @@ -35,6 +35,7 @@ import TransformRequestPanel from "@/components/transform_request"; import UIThemeSettings from "@/components/ui_theme_settings"; import Usage from "@/components/usage"; import UserDashboard from "@/components/user_dashboard"; +import { AccessGroupsPage } from "@/components/AccessGroups/AccessGroupsPage"; import VectorStoreManagement from "@/components/vector_store_management"; import SpendLogsTable from "@/components/view_logs"; import ViewUserDashboard from "@/components/view_users"; @@ -542,6 +543,8 @@ function CreateKeyPageContent() { ) : page == "claude-code-plugins" ? ( + ) : page == "access-groups" ? ( + ) : page == "vector-stores" ? ( ) : page == "new_usage" ? ( diff --git a/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsDetailsPage.test.tsx b/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsDetailsPage.test.tsx new file mode 100644 index 00000000000..db9d25d886f --- /dev/null +++ b/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsDetailsPage.test.tsx @@ -0,0 +1,384 @@ +import { useAccessGroupDetails } from "@/app/(dashboard)/hooks/accessGroups/useAccessGroupDetails"; +import { AccessGroupResponse } from "@/app/(dashboard)/hooks/accessGroups/useAccessGroups"; +import { screen } from "@testing-library/react"; +import userEvent from "@testing-library/user-event"; +import { beforeEach, describe, expect, it, vi } from "vitest"; +import { renderWithProviders } from "../../../tests/test-utils"; +import { AccessGroupDetail } from "./AccessGroupsDetailsPage"; + +vi.mock("@/app/(dashboard)/hooks/accessGroups/useAccessGroupDetails"); +vi.mock("./AccessGroupsModal/AccessGroupEditModal", () => ({ + AccessGroupEditModal: ({ + visible, + onCancel, + }: { + visible: boolean; + onCancel: () => void; + }) => + visible ? ( +
+ +
+ ) : null, +})); + +const mockUseAccessGroupDetails = vi.mocked(useAccessGroupDetails); + +const baseMockReturnValue = { + data: undefined, + isLoading: false, + isError: false, + error: null, + isFetching: false, + isPending: false, + isSuccess: true, + status: "success" as const, + dataUpdatedAt: 0, + errorUpdatedAt: 0, + failureCount: 0, + failureReason: null, + errorUpdateCount: 0, + isFetched: true, + isFetchedAfterMount: true, + isRefetching: false, + isLoadingError: false, + isPaused: false, + isPlaceholderData: false, + isRefetchError: false, + isStale: false, + fetchStatus: "idle" as const, + refetch: vi.fn(), +} as unknown as ReturnType; + +const createMockAccessGroup = ( + overrides: Partial = {} +): AccessGroupResponse => ({ + access_group_id: "ag-1", + access_group_name: "Test Group", + description: "A test access group", + access_model_ids: ["model-1", "model-2"], + access_mcp_server_ids: ["mcp-1"], + access_agent_ids: ["agent-1"], + assigned_team_ids: ["team-1"], + assigned_key_ids: ["key-1", "key-2"], + created_at: "2025-01-01T00:00:00Z", + created_by: null, + updated_at: "2025-01-02T00:00:00Z", + updated_by: null, + ...overrides, +}); + +describe("AccessGroupDetail", () => { + const mockOnBack = vi.fn(); + const accessGroupId = "ag-1"; + + beforeEach(() => { + vi.clearAllMocks(); + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup(), + } as ReturnType); + }); + + it("should render the component", () => { + renderWithProviders( + + ); + expect(screen.getByRole("heading", { name: "Test Group" })).toBeInTheDocument(); + }); + + it("should not show access group content when loading", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: undefined, + isLoading: true, + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.queryByRole("heading", { name: "Test Group" })).not.toBeInTheDocument(); + }); + + it("should show empty state when access group is not found", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: undefined, + isLoading: false, + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByText("Access group not found")).toBeInTheDocument(); + expect(screen.getByRole("button")).toBeInTheDocument(); + }); + + it("should call onBack when back button is clicked", async () => { + const user = userEvent.setup(); + renderWithProviders( + + ); + + const buttons = screen.getAllByRole("button"); + const backButton = buttons.find((btn) => !btn.textContent?.includes("Edit")); + await user.click(backButton!); + + expect(mockOnBack).toHaveBeenCalledTimes(1); + }); + + it("should display access group name and ID", () => { + renderWithProviders( + + ); + + expect(screen.getByRole("heading", { name: "Test Group" })).toBeInTheDocument(); + expect(screen.getByText(/ID:/)).toBeInTheDocument(); + }); + + it("should display description in Group Details", () => { + renderWithProviders( + + ); + + expect(screen.getByText("Group Details")).toBeInTheDocument(); + expect(screen.getByText("A test access group")).toBeInTheDocument(); + }); + + it("should display em dash when description is empty", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ description: null }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByText("—")).toBeInTheDocument(); + }); + + it("should open edit modal when Edit Access Group button is clicked", async () => { + const user = userEvent.setup(); + renderWithProviders( + + ); + + expect(screen.queryByRole("dialog", { name: "Edit Access Group" })).not.toBeInTheDocument(); + + const editButton = screen.getByRole("button", { name: /Edit Access Group/i }); + await user.click(editButton); + + expect(screen.getByRole("dialog", { name: "Edit Access Group" })).toBeInTheDocument(); + }); + + it("should close edit modal when Close Modal is clicked", async () => { + const user = userEvent.setup(); + renderWithProviders( + + ); + + await user.click(screen.getByRole("button", { name: /Edit Access Group/i })); + expect(screen.getByRole("dialog", { name: "Edit Access Group" })).toBeInTheDocument(); + + await user.click(screen.getByRole("button", { name: "Close Modal" })); + expect(screen.queryByRole("dialog", { name: "Edit Access Group" })).not.toBeInTheDocument(); + }); + + it("should display attached keys", () => { + renderWithProviders( + + ); + + expect(screen.getByText("Attached Keys")).toBeInTheDocument(); + expect(screen.getByText("key-1")).toBeInTheDocument(); + expect(screen.getByText("key-2")).toBeInTheDocument(); + }); + + it("should display attached teams", () => { + renderWithProviders( + + ); + + expect(screen.getByText("Attached Teams")).toBeInTheDocument(); + expect(screen.getByText("team-1")).toBeInTheDocument(); + }); + + it("should show View All button for keys when more than 5", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ + assigned_key_ids: ["k1", "k2", "k3", "k4", "k5", "k6"], + }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByRole("button", { name: "View All (6)" })).toBeInTheDocument(); + }); + + it("should toggle between View All and Show Less for keys", async () => { + const user = userEvent.setup(); + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ + assigned_key_ids: ["k1", "k2", "k3", "k4", "k5", "k6"], + }), + } as ReturnType); + + renderWithProviders( + + ); + + await user.click(screen.getByRole("button", { name: "View All (6)" })); + expect(screen.getByRole("button", { name: "Show Less" })).toBeInTheDocument(); + + await user.click(screen.getByRole("button", { name: "Show Less" })); + expect(screen.getByRole("button", { name: "View All (6)" })).toBeInTheDocument(); + }); + + it("should show View All button for teams when more than 5", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ + assigned_team_ids: ["t1", "t2", "t3", "t4", "t5", "t6"], + }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByRole("button", { name: "View All (6)" })).toBeInTheDocument(); + }); + + it("should show empty state when no keys attached", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ assigned_key_ids: [] }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByText("No keys attached")).toBeInTheDocument(); + }); + + it("should show empty state when no teams attached", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ assigned_team_ids: [] }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByText("No teams attached")).toBeInTheDocument(); + }); + + it("should display Models tab with model IDs", () => { + renderWithProviders( + + ); + + expect(screen.getByRole("tab", { name: /Models/i })).toBeInTheDocument(); + expect(screen.getByText("model-1")).toBeInTheDocument(); + expect(screen.getByText("model-2")).toBeInTheDocument(); + }); + + it("should display MCP Servers tab with server IDs", async () => { + const user = userEvent.setup(); + renderWithProviders( + + ); + + const mcpTab = screen.getByRole("tab", { name: /MCP Servers/i }); + expect(mcpTab).toBeInTheDocument(); + await user.click(mcpTab); + expect(screen.getByText("mcp-1")).toBeInTheDocument(); + }); + + it("should display Agents tab with agent IDs", async () => { + const user = userEvent.setup(); + renderWithProviders( + + ); + + const agentsTab = screen.getByRole("tab", { name: /Agents/i }); + expect(agentsTab).toBeInTheDocument(); + await user.click(agentsTab); + expect(screen.getByText("agent-1")).toBeInTheDocument(); + }); + + it("should show empty state in Models tab when no models assigned", () => { + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ access_model_ids: [] }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByText("No models assigned to this group")).toBeInTheDocument(); + }); + + it("should show empty state in MCP Servers tab when none assigned", async () => { + const user = userEvent.setup(); + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ access_mcp_server_ids: [] }), + } as ReturnType); + + renderWithProviders( + + ); + + await user.click(screen.getByRole("tab", { name: /MCP Servers/i })); + expect(screen.getByText("No MCP servers assigned to this group")).toBeInTheDocument(); + }); + + it("should show empty state in Agents tab when none assigned", async () => { + const user = userEvent.setup(); + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ access_agent_ids: [] }), + } as ReturnType); + + renderWithProviders( + + ); + + await user.click(screen.getByRole("tab", { name: /Agents/i })); + expect(screen.getByText("No agents assigned to this group")).toBeInTheDocument(); + }); + + it("should truncate long key IDs with ellipsis", () => { + const longKeyId = "a".repeat(25); + mockUseAccessGroupDetails.mockReturnValue({ + ...baseMockReturnValue, + data: createMockAccessGroup({ assigned_key_ids: [longKeyId] }), + } as ReturnType); + + renderWithProviders( + + ); + + expect(screen.getByText(/a{10}\.\.\.a{6}/)).toBeInTheDocument(); + }); + + it("should display created and last updated timestamps", () => { + renderWithProviders( + + ); + + expect(screen.getByText("Created")).toBeInTheDocument(); + expect(screen.getByText("Last Updated")).toBeInTheDocument(); + }); +}); diff --git a/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsDetailsPage.tsx b/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsDetailsPage.tsx new file mode 100644 index 00000000000..9b794959baa --- /dev/null +++ b/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsDetailsPage.tsx @@ -0,0 +1,345 @@ +import { useAccessGroupDetails } from "@/app/(dashboard)/hooks/accessGroups/useAccessGroupDetails"; +import { + Button, + Card, + Col, + Descriptions, + Empty, + Flex, + Layout, + List, + Row, + Spin, + Tabs, + Tag, + theme, + Typography +} from "antd"; +import { + ArrowLeftIcon, + BotIcon, + EditIcon, + KeyIcon, + LayersIcon, + ServerIcon, + UsersIcon, +} from "lucide-react"; +import { useState } from "react"; +import DefaultProxyAdminTag from "../common_components/DefaultProxyAdminTag"; +import { AccessGroupEditModal } from "./AccessGroupsModal/AccessGroupEditModal"; + +const { Title, Text } = Typography; +const { Content } = Layout; + +interface AccessGroupDetailProps { + accessGroupId: string; + onBack: () => void; +} + +export function AccessGroupDetail({ + accessGroupId, + onBack, +}: AccessGroupDetailProps) { + const { data: accessGroup, isLoading } = + useAccessGroupDetails(accessGroupId); + const { token } = theme.useToken(); + const [isEditModalVisible, setIsEditModalVisible] = useState(false); + const [showAllKeys, setShowAllKeys] = useState(false); + const [showAllTeams, setShowAllTeams] = useState(false); + + const MAX_PREVIEW = 5; + + if (isLoading) { + return ( + + + + + + ); + } + + if (!accessGroup) { + return ( + + + + + {/* Group Details */} + + + + + {accessGroup.description || "—"} + + + {new Date(accessGroup.created_at).toLocaleString()} + {accessGroup.created_by && ( + +  {"by"}  + + + )} + + + {new Date(accessGroup.updated_at).toLocaleString()} + {accessGroup.updated_by && ( + +  {"by"}  + + + )} + + + + + + {/* Attached Keys & Teams */} + + + + + Attached Keys + {keyIds.length} + + } + extra={ + keyIds.length > MAX_PREVIEW ? ( + + ) : null + } + > + {keyIds.length > 0 ? ( + + {displayedKeys.map((id) => ( + + + {id.length > 20 + ? `${id.slice(0, 10)}...${id.slice(-6)}` + : id} + + + ))} + + ) : ( + + )} + + + + + + Attached Teams + {teamIds.length} + + } + extra={ + teamIds.length > MAX_PREVIEW ? ( + + ) : null + } + > + {teamIds.length > 0 ? ( + + {displayedTeams.map((id) => ( + + + {id} + + + ))} + + ) : ( + + )} + + + + + {/* Resources Tabs */} + + + + + {/* Edit Modal */} + setIsEditModalVisible(false)} + /> + + ); +} diff --git a/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsModal/AccessGroupBaseForm.tsx b/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsModal/AccessGroupBaseForm.tsx new file mode 100644 index 00000000000..df60457571e --- /dev/null +++ b/ui/litellm-dashboard/src/components/AccessGroups/AccessGroupsModal/AccessGroupBaseForm.tsx @@ -0,0 +1,159 @@ +import { useAgents } from "@/app/(dashboard)/hooks/agents/useAgents"; +import { useMCPServers } from "@/app/(dashboard)/hooks/mcpServers/useMCPServers"; +import { ModelSelect } from "@/components/ModelSelect/ModelSelect"; +import type { FormInstance } from "antd"; +import { Form, Input, Select, Space, Tabs } from "antd"; +import { BotIcon, InfoIcon, LayersIcon, ServerIcon } from "lucide-react"; + +const { TextArea } = Input; + +export interface AccessGroupFormValues { + name: string; + description: string; + modelIds: string[]; + mcpServerIds: string[]; + agentIds: string[]; +} + +interface AccessGroupBaseFormProps { + form: FormInstance; + isNameDisabled?: boolean; +} + +export function AccessGroupBaseForm({ + form, + isNameDisabled = false, +}: AccessGroupBaseFormProps) { + const { data: agentsData } = useAgents(); + const { data: mcpServersData } = useMCPServers(); + + const agents = agentsData?.agents ?? []; + const mcpServers = mcpServersData ?? []; + const items = [ + { + key: "1", + label: ( + + + General Info + + ), + children: ( +
+ + + + +