From 0bc7c54f5c62b7498c30111be86a1862cd2aa918 Mon Sep 17 00:00:00 2001 From: shin-bot-litellm Date: Sat, 31 Jan 2026 08:16:09 +0000 Subject: [PATCH] fix(proxy): reduce PLR0915 complexity in base_process_llm_request Extract model_id fallback logic into _get_model_id_from_response helper to reduce statement count from 54 to 49 (under the 50 limit). --- litellm/proxy/common_request_processing.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/litellm/proxy/common_request_processing.py b/litellm/proxy/common_request_processing.py index 136ce69651..6fd77fab7a 100644 --- a/litellm/proxy/common_request_processing.py +++ b/litellm/proxy/common_request_processing.py @@ -623,6 +623,16 @@ async def common_processing_pre_call_logic( return self.data, logging_obj + @staticmethod + def _get_model_id_from_response(hidden_params: dict, data: dict) -> str: + """Extract model_id from hidden_params with fallback to litellm_metadata.""" + model_id = hidden_params.get("model_id", None) or "" + if not model_id: + litellm_metadata = data.get("litellm_metadata", {}) or {} + model_info = litellm_metadata.get("model_info", {}) or {} + model_id = model_info.get("id", "") or "" + return model_id + async def base_process_llm_request( self, request: Request, @@ -757,13 +767,7 @@ async def base_process_llm_request( response = responses[1] hidden_params = getattr(response, "_hidden_params", {}) or {} - model_id = hidden_params.get("model_id", None) or "" - - # Fallback: extract model_id from litellm_metadata if not in hidden_params - if not model_id: - litellm_metadata = self.data.get("litellm_metadata", {}) or {} - model_info = litellm_metadata.get("model_info", {}) or {} - model_id = model_info.get("id", "") or "" + model_id = self._get_model_id_from_response(hidden_params, self.data) cache_key, api_base, response_cost = ( hidden_params.get("cache_key", None) or "",