Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for ZNPCs/FancyNPCs and DecentHolograms/FancyHolograms #2569

Open
2 tasks done
Zarkness opened this issue Dec 7, 2024 · 10 comments
Open
2 tasks done
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: In progress Working on the issue.

Comments

@Zarkness
Copy link

Zarkness commented Dec 7, 2024

Is your feature request related to a problem?

Currently, BentoBox lacks support for NPC and hologram plugins like Citizens and HolographicDisplays, as highlighted in the following issues:

#1195: hook to citizens
#1129: Add support for Citizens and holographicdisplays
While support for Citizens and HolographicDisplays is highly requested, many server owners prefer more optimized, client-side alternatives, such as ZNPCs and FancyNPCs for NPCs, and DecentHolograms or FancyHolograms for holographic text displays. Adding support for these plugins would allow BentoBox to cater to a wider range of setups, especially performance-conscious servers.

Describe the solution you'd like.

ZNPCs and FancyNPCs Support:

Implement compatibility with ZNPCs and FancyNPCs as lightweight, client-side alternatives to Citizens.
Allow these plugins to handle NPC-related features (e.g., island-specific NPCs) seamlessly within BentoBox.
DecentHolograms and FancyHolograms Support:

Add support for DecentHolograms and FancyHolograms as alternatives to HolographicDisplays, reducing server load and providing modern, optimized solutions for holographic text.
Automatically detect and use the installed hologram plugin, with fallback options based on availability.
General Compatibility:

Implement a detection system to prioritize and support multiple NPC and hologram plugins, offering server administrators the flexibility to choose the plugins that best suit their needs.

Describe alternatives you've considered.

Adding only Citizens and HolographicDisplays support, as requested in issues #1129 and #1195. While this would address the lack of support for these popular plugins, it would not account for the growing use of optimized, client-side alternatives like ZNPCs and DecentHolograms.
Relying on server-side workarounds or manual scripting to integrate alternative plugins, which increases complexity and may lead to compatibility issues

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

By building on the foundation of issues #1129 and #1195, this request extends BentoBox's capabilities to include support for optimized plugins like ZNPCs and FancyNPCs for NPC handling, and DecentHolograms and FancyHolograms for holographic text. These plugins provide client-side efficiency and performance benefits, making them highly desirable for modern server setups.

Adding support for these alternatives would make BentoBox more versatile, appealing to server administrators looking for lightweight and high-performance options.

@tastybento
Copy link
Member

FancyNPC support has been added in #2570 and is available in the SNAPSHOT latest release.

@tastybento tastybento self-assigned this Dec 8, 2024
@tastybento tastybento added Status: In progress Working on the issue. Status: Done This issue has been completed or answered. This pull request has been merged. labels Dec 8, 2024
@Zarkness
Copy link
Author

Zarkness commented Dec 8, 2024

ok, I'll be waiting for the other 3 plugins you mentioned, thank you very much.

@tastybento
Copy link
Member

ZNPCS has no documented API, sorry. It claims in the Spigot plugin page it does, but there's nothing. So that one will not be supportable.

@Zarkness
Copy link
Author

ZNPCS has no documented API, sorry. It claims in the Spigot plugin page it does, but there's nothing. So that one will not be supportable.

Hi, I do not know where you saw, because I went to github, then section wiki, api docs and then javadoc here I leave you the links, maybe on the one hand was my fault for not saying zpncplus, if so sorry

https://github.com/Pyrbu/ZNPCsPlus/wiki/API
https://repo.pyr.lol/javadoc/snapshots/lol/pyr/znpcsplus-api/2.0.0-SNAPSHOT

@tastybento
Copy link
Member

Aha. Okay. I'll check that out.

@tastybento
Copy link
Member

Trying to get some help for it: Pyrbu/ZNPCsPlus#163

@tastybento
Copy link
Member

ZNPCPlus is done. #2575

@Zarkness
Copy link
Author

thanks

@tastybento
Copy link
Member

FancyHolograms does not seem to have a fully fleshed out API. So, for now I've added full support for vanilla text, item and block holograms (what you can get from summon commands, for example). These can be saved in blueprints and when pasted can be broken by the player using right click (except for block holograms right now).

@Zarkness
Copy link
Author

okey, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: In progress Working on the issue.
Projects
None yet
Development

No branches or pull requests

2 participants