Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashing to an unknown partition causes a crash #536

Open
goeranu opened this issue Mar 4, 2024 · 0 comments
Open

Flashing to an unknown partition causes a crash #536

goeranu opened this issue Mar 4, 2024 · 0 comments

Comments

@goeranu
Copy link

goeranu commented Mar 4, 2024

When installing LineageOS recently, I used heimdall in place of the Windows Odin package used in the description from LineageOS. Googling I found a hit where the partition number was used to identify where to write the recovery image. Actually doing that though, resulted in heimdall crashing.

Looking at the problem afterwards using gdb I realise this is in the function flashPartition where the code first assigns part from pitData->FindEntry(it->argumentName), and then uses the value without checking if it was null. See the attached gdb session. It seems to me a check should be added to see if part is null, and if so write an error message rather than just crashing.

This was done on a Fedora 39 system with heimdall-2.0.2-3.fc39.x86_64.
gdb-session.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant