Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document try/catch in native enum conversion #338

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Document try/catch in native enum conversion #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ Review and validate the code changes for missed edge cases:
- `Enum::coerce()`: If only values were passed, you can replace it with `tryFrom()`.
If keys or instances could also be passed, you might need additional logic to cover this.
- `Enum::$description` and `Enum::getDescription()`: Implement an alternative.
- try/catch-blocks that handle `BenSampo\Enum\Exceptions\InvalidEnumKeyException` or `BenSampo\Enum\Exceptions\InvalidEnumMemberException`.
Either catch the `ValueError` thrown by native enums, or switch to using `tryFrom()` and handle `null`.

Once all enums are converted, you can remove your dependency on this library.

Expand Down
Loading