Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: WinKey as modifier #109

Closed
stavfx opened this issue Jul 29, 2016 · 6 comments
Closed

Request: WinKey as modifier #109

stavfx opened this issue Jul 29, 2016 · 6 comments
Labels
Confirmed Confirmed issues Enhancement Issue which are a enhancement

Comments

@stavfx
Copy link

stavfx commented Jul 29, 2016

Thanks for making exactly the utility I was looking for!

I only wish that the WinKey will be treated as a modifier key, so I could bind something like "Win+A" or "Win+Shift+A".

Thanks again!

@Belphemur Belphemur added the Enhancement Issue which are a enhancement label Jul 31, 2016
@Belphemur
Copy link
Owner

Should be easily doable, I'll give it a lot asap.

@Belphemur Belphemur added the Confirmed Confirmed issues label Aug 10, 2016
@Belphemur Belphemur added the InBeta Issues which are related to a beta or pre-release label Aug 21, 2016
@Belphemur
Copy link
Owner

Belphemur commented Aug 21, 2016

In fact it wasn't easy.

C# is doing its best to be sure the developer won't use the WinKey ... Anyway, it's done and working.
If you could also test it, that'd be great.

@Technetium1
Copy link

@Belphemur Works perfectly for me on Windows 10 x64.

@stavfx
Copy link
Author

stavfx commented Aug 22, 2016

It works on Win 7 x64!
However there's a small visual issue, as you'll see in the attached photos. It behaves a little differently than the other modifier keys.
ssalt
sswin

Like I said, This is a visual issue only, and the key binding works perfectly as expected (so I'm happy with the current state).

Thanks!!

@Belphemur
Copy link
Owner

Yeah I'm aware of the little glitch.

It's because C# doesn't recognize the windows key as a modifier (like ctrl, alt or shift), I had to interface directly with one of the windows library to catch the Win key and other key pressed in the same time.

For C#, in this case, the Win key is not pressed, only the A key. I'll see later if I can do something about the key appearing like this.

@Technetium1
Copy link

This doesn't happen on Windows 10.
settings

@Belphemur Belphemur removed the InBeta Issues which are related to a beta or pre-release label Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Confirmed issues Enhancement Issue which are a enhancement
Projects
None yet
Development

No branches or pull requests

3 participants