fix(Device::Selection): Fix issue with recording and playback device having the same name not appearing in selected devices.

Fixes #1070

Author: Belphemur

SoundSwitch.Common/Framework/Audio/Collection/DeviceCollection.cs

@@ -21,10 +21,18 @@ public DeviceCollection(IEnumerable<T> deviceInfos)
             }
 
             _byId[item.Id] = item;
-            _byName[item.NameClean] = item;
+            _byName[GetNameKey(item)] = item;
         }
     }
 
+    /// <summary>
+    /// Generate a key that merge together the type of device and their name.
+    /// </summary>
+    /// <remarks>Recording and Playback device can share the same name, this is done to avoid conflict between the two</remarks>
+    /// <param name="item"></param>
+    /// <returns></returns>
+    private string GetNameKey(T item) => $"{item.Type}-{item.NameClean}";
+
     public IEnumerator<T> GetEnumerator()
     {
         return _byId.Values.OrderBy(info => info.DiscoveredAt).GetEnumerator();
@@ -43,7 +51,7 @@ public void Add(T item)
         }
 
         _byId.TryAdd(item.Id, item);
-        _byName.TryAdd(item.NameClean, item);
+        _byName.TryAdd(GetNameKey(item), item);
     }
 
     public void Clear()
@@ -59,8 +67,7 @@ public bool Contains(T item)
             throw new ArgumentNullException();
         }
 
-        return _byId.ContainsKey(item.Id) || _byName.ContainsKey(item.NameClean);
-        
+        return _byId.ContainsKey(item.Id) || _byName.ContainsKey(GetNameKey(item));
     }
 
     public void CopyTo(T[] array, int arrayIndex)
@@ -76,12 +83,13 @@ public bool Remove(T item)
         }
 
         var removeId = _byId.Remove(item.Id);
-        var removeName = _byName.Remove(item.NameClean, out var removedByName);
+        var removeName = _byName.Remove(GetNameKey(item), out var removedByName);
 
         //If we found it by name, remove it also with it's id
         //this avoid the case that a device is removed because of name matching
         //but it's still used since we iterate the _byId
-        if(removeName) {
+        if (removeName)
+        {
             _byId.Remove(removedByName.Id);
         }
 

SoundSwitch.Common/Framework/Audio/Device/DeviceInfo.cs

@@ -51,7 +51,7 @@ public DeviceInfo(MMDevice device)
             Id = device.ID;
             Type = device.DataFlow;
             var deviceProperties = device.Properties;
-            var enumerator = deviceProperties.Contains(PropertyKeys.DEVPKEY_Device_EnumeratorName) ? (string) deviceProperties[PropertyKeys.DEVPKEY_Device_EnumeratorName].Value : "";
+            var enumerator = deviceProperties.Contains(PropertyKeys.DEVPKEY_Device_EnumeratorName) ? (string)deviceProperties[PropertyKeys.DEVPKEY_Device_EnumeratorName].Value : "";
             IsUsb = enumerator == "USB";
         }
 
@@ -94,7 +94,7 @@ public bool Equals(DeviceInfo other)
             //help recognizing the same device
             return NameClean == other.NameClean;
         }
-        
+
         public override bool Equals(object obj)
         {
             if (ReferenceEquals(null, obj))
@@ -117,7 +117,7 @@ public override bool Equals(object obj)
 
         public override int GetHashCode()
         {
-            return HashCode.Combine(NameClean, Id);
+            return HashCode.Combine(Type, NameClean, Id);
         }
     }
 }