fix(Updater::Download): Fix missing user agent for downloading release

Author: Belphemur

SoundSwitch/Framework/Updater/ApplicationInfo.cs

@@ -0,0 +1,11 @@
+using System.Net.Http.Headers;
+using System.Windows.Forms;
+
+namespace SoundSwitch.Framework.Updater
+{
+    internal static class ApplicationInfo
+    {
+        public static readonly ProductInfoHeaderValue ProductValue = new ProductInfoHeaderValue(Application.ProductName, Application.ProductVersion);
+        public static readonly ProductInfoHeaderValue CommentValue = new ProductInfoHeaderValue("(+https://soundwitch.aaflalo.me)");
+    }
+}

SoundSwitch/Framework/Updater/FileDownloader.cs

@@ -49,6 +49,8 @@ public static async Task DownloadFileAsync(Uri uri, Stream toStream, Cancellatio
             else
             {
                 using var client = new HttpClient();
+                client.DefaultRequestHeaders.UserAgent.Add(ApplicationInfo.ProductValue);
+                client.DefaultRequestHeaders.UserAgent.Add(ApplicationInfo.CommentValue);
                 using var response = await client.GetAsync(uri, HttpCompletionOption.ResponseHeadersRead, cancellationToken).ConfigureAwait(false);
 
                 if (progressCallback != null)

SoundSwitch/Framework/Updater/UpdateChecker.cs

@@ -35,8 +35,6 @@ public class UpdateChecker
 
         private readonly Uri _releaseUrl;
         public EventHandler<NewReleaseEvent> UpdateAvailable;
-        private static readonly ProductInfoHeaderValue ProductValue;
-        private static readonly ProductInfoHeaderValue CommentValue;
         public bool Beta { get; set; }
 
         public UpdateChecker(Uri releaseUrl) : this(releaseUrl, false)
@@ -49,12 +47,6 @@ public UpdateChecker(Uri releaseUrl, bool checkBeta)
             Beta = checkBeta;
         }
 
-        static UpdateChecker()
-        {
-            ProductValue = new ProductInfoHeaderValue(Application.ProductName, Application.ProductVersion);
-            CommentValue = new ProductInfoHeaderValue("(+https://soundwitch.aaflalo.me)");
-        }
-
         private bool ProcessRelease(GitHubRelease serverRelease)
         {
             Log.Information("Checking version {version} ", serverRelease);
@@ -97,8 +89,8 @@ private bool ProcessRelease(GitHubRelease serverRelease)
         public async Task CheckForUpdate(CancellationToken token)
         {
             using var httpClient = new HttpClient(new SentryHttpMessageHandler());
-            httpClient.DefaultRequestHeaders.UserAgent.Add(ProductValue);
-            httpClient.DefaultRequestHeaders.UserAgent.Add(CommentValue);
+            httpClient.DefaultRequestHeaders.UserAgent.Add(ApplicationInfo.ProductValue);
+            httpClient.DefaultRequestHeaders.UserAgent.Add(ApplicationInfo.CommentValue);
             httpClient.DefaultRequestHeaders.Accept.Add(MediaTypeWithQualityHeaderValue.Parse("application/json"));
             var releases = await httpClient.GetFromJsonAsync<GitHubRelease[]>(_releaseUrl, token);
             foreach (var release in releases ?? Array.Empty<GitHubRelease>())